From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [PATCH 1/2] drm/radeon: fix fence related segfault in CS Date: Tue, 31 Jul 2012 16:47:50 +0200 Message-ID: <1343746070.17626.100.camel@thor.local> References: <1343735331-4922-1-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C77E9E793 for ; Tue, 31 Jul 2012 07:48:01 -0700 (PDT) In-Reply-To: <1343735331-4922-1-git-send-email-deathsimple@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Christian =?ISO-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Die, 2012-07-31 at 13:48 +0200, Christian K=F6nig wrote: = > Don't return success if scheduling the IB fails, otherwise > we end up with an oops in ttm_eu_fence_buffer_objects. > = > Signed-off-by: Christian K=F6nig > Reviewed-by: Alex Deucher > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/radeon/radeon_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/= radeon_cs.c > index 142f894..17238f4 100644 > --- a/drivers/gpu/drm/radeon/radeon_cs.c > +++ b/drivers/gpu/drm/radeon/radeon_cs.c > @@ -377,7 +377,7 @@ static int radeon_cs_ib_chunk(struct radeon_device *r= dev, > if (r) { > DRM_ERROR("Failed to schedule IB !\n"); > } > - return 0; > + return r; > } > = > static int radeon_bo_vm_update_pte(struct radeon_cs_parser *parser, AFAICT this fix is already in Linus' tree (commit 93bf888c5c730605e3470f5d2381f296eda88d79). -- = Earthling Michel D=E4nzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer