All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Greg Kroah-Hartman <greg@kroah.com>,
	Ben Widawsky <ben@bwidawsk.net>,
	dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: Massive power regression going 3.4->3.5
Date: Tue, 31 Jul 2012 20:24:19 +0100	[thread overview]
Message-ID: <1343762668_23120@CP5-2952> (raw)
In-Reply-To: <1343729665_21195@CP5-2952>

On Tue, 31 Jul 2012 11:14:17 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, 31 Jul 2012 10:57:10 +0100, James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> > > When did you inspect the debug files? One effect I can imagine is that
> > > if your system was previously stuck at RPn and never upclocking the GPU
> > > when X starts. The question would then be what is preventing the GPU
> > > from reaching its lowest power state again.
> > 
> > After I logged into an xfce4 session and powertop showed idle had been
> > reached.

That you are using xfce4 makes the use of semaphores for pageflips as
being the root cause even more suspect. Pageflips are only used for a
fullscreen DRI client caalling SwapBuffers, to my knowledge xfce4 does
not use DRI at all - its compositing manager is XRender based if you
happen to be using it.

Please can you try the small patch to disable the use of semaphores for
pageflips and see if the regression remains (which I judge it will...):

diff --git a/drivers/gpu/drm/i915/i915_gem.c
b/drivers/gpu/drm/i915/i915_gem.c
index 5c4657a..f301f2f 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3067,7 +3067,7 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_o
                return ret;
 
        if (pipelined != obj->ring) {
-               ret = i915_gem_object_sync(obj, pipelined);
+               ret = i915_gem_object_wait_rendering(obj);
                if (ret)
                        return ret;
        }

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-07-31 19:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1343477958.2891.6.camel@dabdike.int.hansenpartnership.com>
     [not found] ` <1343557599.2745.1.camel@dabdike.int.hansenpartnership.com>
     [not found]   ` <201207291544.26334.rjw@sisk.pl>
     [not found]     ` <201207292125.21376.rjw@sisk.pl>
     [not found]       ` <1343641574.2905.2.camel@dabdike.int.hansenpartnership.com>
2012-07-30 14:54         ` Massive power regression going 3.4->3.5 James Bottomley
2012-07-30 16:33           ` Keith Packard
2012-07-30 17:05             ` James Bottomley
2012-07-30 18:23               ` Keith Packard
2012-07-31  7:31                 ` James Bottomley
2012-07-31  8:06                   ` James Bottomley
2012-07-31  8:28                     ` Chris Wilson
2012-07-31  9:37                       ` James Bottomley
2012-07-31  9:54                         ` Chris Wilson
2012-07-31  9:57                           ` James Bottomley
2012-07-31 10:14                             ` Chris Wilson
2012-07-31 19:24                               ` Chris Wilson [this message]
2012-08-01  8:06                                 ` James Bottomley
2012-08-01  8:16                                   ` Chris Wilson
2012-08-01  8:45                                     ` James Bottomley
2012-08-01  8:58                                       ` Chris Wilson
2012-08-01  9:07                                         ` James Bottomley
2012-08-01  9:14                                           ` Chris Wilson
2012-08-01  9:38                                         ` James Bottomley
2012-08-01 10:06                                           ` Chris Wilson
2012-08-02  5:08                                             ` bwidawsk
2012-08-02  7:20                                               ` James Bottomley
2012-08-02 12:07                                                 ` Ben Widawsky
2012-08-01 10:08                                         ` James Bottomley
2012-08-05 20:36                                           ` Daniel Vetter
2012-08-07 20:43                                             ` James Bottomley
2012-08-08  2:44                                               ` Ben Widawsky
2012-08-08  7:22                                               ` Daniel Vetter
2012-08-06 19:31                                   ` [PATCH] drm/i915: make forcewake work again Ben Widawsky
2012-08-07 17:56                                     ` [Intel-gfx] " Ben Widawsky
2012-07-31 14:27                     ` Massive power regression going 3.4->3.5 Keith Packard
2012-07-31 15:09                       ` James Bottomley
2012-07-31 15:36                         ` Chris Wilson
2012-07-31 16:25                         ` James Bottomley
2012-07-30 18:23               ` Adam Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343762668_23120@CP5-2952 \
    --to=chris@chris-wilson.co.uk \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ben@bwidawsk.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=greg@kroah.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.