From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Iegorov Oleg" <oleg_iegorov@mentor.com>,
linux-perf-users@vger.kernel.org, mingo@elte.hu,
acme@ghostprotocols.net,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Arnaldo Carvalho de Melo" <acme@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: perf: prctl(PR_TASK_PERF_EVENTS_DISABLE) has no effect
Date: Tue, 31 Jul 2012 21:48:52 +0200 [thread overview]
Message-ID: <1343764132.20897.40.camel@twins> (raw)
In-Reply-To: <20120731071600.GB2950@gmail.com>
On Tue, 2012-07-31 at 09:16 +0200, Ingo Molnar wrote:
> * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> > On Fri, 2012-07-27 at 13:53 +0200, Ingo Molnar wrote:
> > > > Bloating the interface for something that is already well
> > > > possible is.
> > >
> > > There's no 'bloat' worth speaking off: a single bit out of
> > > an already allocated bitmap, plus a single check in an
> > > already existing loop,
> >
> > Uhm, no. The existing prctl() loop is over the fd's the task
> > owns, you want a loop over the fd's that monitor you. This
> > needs new prctl()s at the very least.
>
> We could add a new prctl if you think, but I thought to not
> complicate it and offer it as a simple extension of the
> semantics to loop over active events. No existing binary's
> behavior will change.
It muddles up the semantics of the existing prctl()s though.
Ideally we'd simply remove the current ones though, I don't think
anybody actually uses them and as an owner you actually have all the fds
to call ioctl() on.
This would let us get rid of the entire event->owner, event->owner_entry
and task->perf_event_list mess. See perf_event_exit_task() and
perf_release() for why I'd love that crap to go away.
next prev parent reply other threads:[~2012-07-31 19:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 10:54 perf: prctl(PR_TASK_PERF_EVENTS_DISABLE) has no effect Iegorov Oleg
2012-07-27 7:26 ` Ingo Molnar
2012-07-27 8:00 ` Peter Zijlstra
2012-07-27 8:18 ` Ingo Molnar
2012-07-27 8:29 ` Peter Zijlstra
2012-07-27 11:40 ` Iegorov Oleg
2012-07-27 11:53 ` Ingo Molnar
2012-07-30 20:04 ` Andi Kleen
2012-07-31 5:47 ` Peter Zijlstra
2012-07-31 7:16 ` Ingo Molnar
2012-07-31 19:48 ` Peter Zijlstra [this message]
2012-07-27 11:56 ` [RFD] perf: events defined contexts (was Re: perf: prctl(PR_TASK_PERF_EVENTS_DISABLE) has no effect) Frederic Weisbecker
2012-07-27 12:45 ` Jiri Olsa
2012-08-06 1:41 ` Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2012-01-27 17:03 perf: prctl(PR_TASK_PERF_EVENTS_DISABLE) has no effect Andrew Steets
2012-01-27 17:12 ` Peter Zijlstra
2012-01-27 20:06 ` Andrew Steets
2012-01-27 21:34 ` Peter Zijlstra
2012-01-28 12:01 ` Ingo Molnar
2012-01-28 23:48 ` Andrew Steets
2012-01-29 16:32 ` Ingo Molnar
2012-01-29 16:32 ` Ingo Molnar
2012-01-29 17:50 ` Gleb Natapov
2012-01-30 9:52 ` Peter Zijlstra
2012-01-30 10:11 ` Ingo Molnar
2012-01-30 11:01 ` Peter Zijlstra
2012-01-30 11:31 ` Ingo Molnar
2012-01-30 13:45 ` Peter Zijlstra
2012-01-30 13:58 ` Ingo Molnar
2012-01-30 15:30 ` Arnaldo Carvalho de Melo
2012-01-30 15:29 ` Arnaldo Carvalho de Melo
2012-02-01 19:03 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343764132.20897.40.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=acme@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=oleg_iegorov@mentor.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.