From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============5568187492945948425=="
MIME-Version: 1.0
From: Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH_v3 3/3] test: Add hangup-call script for GCF testing
Date: Thu, 02 Aug 2012 12:21:16 -0700
Message-ID: <1343935276.2083.6.camel@aeonflux>
In-Reply-To: <1343900463-24917-4-git-send-email-guillaume.zajac@linux.intel.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============5568187492945948425==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Guillaume,

>  Makefile.am      |    3 ++-
>  test/hangup-call |   39 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 41 insertions(+), 1 deletions(-)
>  create mode 100755 test/hangup-call
> =

> diff --git a/Makefile.am b/Makefile.am
> index a689483..534245e 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -624,7 +624,8 @@ test_scripts =3D test/backtrace \
>  		test/swap-calls \
>  		test/release-and-answer \
>  		test/hold-and-answer \
> -		test/hangup-call-state
> +		test/hangup-call-state \
> +		test/hangup-call
>  =

>  if TEST
>  testdir =3D $(pkglibdir)/test
> diff --git a/test/hangup-call b/test/hangup-call
> new file mode 100755
> index 0000000..926efc4
> --- /dev/null
> +++ b/test/hangup-call
> @@ -0,0 +1,39 @@
> +#!/usr/bin/python
> +
> +import sys
> +import dbus
> +
> +bus =3D dbus.SystemBus()
> +
> +manager =3D dbus.Interface(bus.get_object('org.ofono', '/'),
> +						'org.ofono.Manager')
> +
> +modems =3D manager.GetModems()
> +path =3D modems[0][0]
> +
> +manager =3D dbus.Interface(bus.get_object('org.ofono', path),
> +						'org.ofono.VoiceCallManager')
> +
> +calls =3D manager.GetCalls()
> +if (len(calls) =3D=3D 0):
> +	print "No calls available"
> +	sys.exit(1)
> +
> +if (len(sys.argv) < 2):
> +	i =3D 0
> +	for path, properties in calls:
> +		multi =3D properties["Multiparty"]
> +		print "Call ID [ %d ] Multiparty %d" % (i, multi)
> +		print
> +		i +=3D 1
> +
> +	print "Usage: %s [ Call ID ]" % (sys.argv[0])
> +	print
> +	sys.exit(1)
> +
> +path =3D calls[int(sys.argv[1])][0]
> +
> +call =3D dbus.Interface(bus.get_object('org.ofono', path),
> +						'org.ofono.VoiceCall')
> +
> +call.Hangup()

why are we not just asking to provide the object path as argument and
then list-calls can be used to determine which call to hang up. That way
also the hangup-call-state hack is not needed.

Using the object path also makes this less racy since we identify the
call by object path and not a random number that might no longer be
valid.

Regards

Marcel



--===============5568187492945948425==--