All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Spelvin <linux@horizon.com>
To: vda.linux@googlemail.com, mina86@mina86.com
Cc: hughd@google.com, linux-kernel@vger.kernel.org, linux@horizon.com
Subject: [PATCH 4/4] lib: vsprintf: Fix broken comments
Date: Fri,  3 Aug 2012 01:21:11 -0400	[thread overview]
Message-ID: <1343971271-13355-4-git-send-email-linux@horizon.com> (raw)
In-Reply-To: <1343971271-13355-1-git-send-email-linux@horizon.com>

Numbering the 8 potential digits 2 though 9 never did make a lot of sense.

Signed-off-by: George Spelvin <linux@horizon.com>
---
 lib/vsprintf.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 3ca77b8..692e61b 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -182,19 +182,19 @@ char *put_dec_trunc8(char *buf, unsigned r)
 
 	if (r == 0)
 		return buf;
-	q      = (r * 0x199a) >> 16;
-	*buf++ = (r - 10 * q)  + '0'; /* 6 */
+	q      = (r * 0x199a) >> 16;	/* r <= 9999 */
+	*buf++ = (r - 10 * q)  + '0';
 	if (q == 0)
 		return buf;
-	r      = (q * 0xcd) >> 11;
-	*buf++ = (q - 10 * r)  + '0'; /* 7 */
+	r      = (q * 0xcd) >> 11;	/* q <= 999 */
+	*buf++ = (q - 10 * r)  + '0';
 	if (r == 0)
 		return buf;
-	q      = (r * 0xcd) >> 11;
-	*buf++ = (r - 10 * q) + '0'; /* 8 */
+	q      = (r * 0xcd) >> 11;	/* r <= 99 */
+	*buf++ = (r - 10 * q) + '0';
 	if (q == 0)
 		return buf;
-	*buf++ = q + '0'; /* 9 */
+	*buf++ = q + '0';		/* q <= 9 */
 	return buf;
 }
 
-- 
1.7.10.4


  parent reply	other threads:[~2012-08-03  5:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03  5:21 [PATCH 1/4] lib: vsprintf: Optimize division by 10 for small integers George Spelvin
2012-08-03  5:21 ` [PATCH 2/4] lib: vsprintf: Optimize division by 10000 George Spelvin
2012-09-23 17:30   ` Michal Nazarewicz
2012-09-24 12:16     ` George Spelvin
2012-09-24 12:41       ` Michal Nazarewicz
2012-09-24 13:56         ` George Spelvin
2012-09-24 15:14           ` Geert Uytterhoeven
2012-09-24 15:48             ` George Spelvin
2012-09-24  9:03   ` Denys Vlasenko
2012-09-24 12:35     ` George Spelvin
2012-09-24 15:02       ` Denys Vlasenko
2012-08-03  5:21 ` [PATCH 3/4] lib: vsprintf: Optimize put_dec_trunc8 George Spelvin
2012-09-23 14:18   ` Rabin Vincent
2012-09-24 11:13     ` George Spelvin
2012-09-24 14:33     ` George Spelvin
2012-09-24 14:53       ` Michal Nazarewicz
2012-09-24 14:57         ` Michal Nazarewicz
2012-09-23 18:22   ` Michal Nazarewicz
2012-09-24 11:46     ` George Spelvin
2012-09-24 12:29       ` Michal Nazarewicz
2012-09-24 13:49         ` George Spelvin
2012-09-24 15:06           ` Michal Nazarewicz
2012-09-25 11:44           ` George Spelvin
2012-09-25 13:00             ` Denys Vlasenko
2012-08-03  5:21 ` George Spelvin [this message]
2012-09-23 17:22 ` [PATCH 1/4] lib: vsprintf: Optimize division by 10 for small integers Michal Nazarewicz
2012-09-24 14:18   ` George Spelvin
2012-09-24  9:06 ` Denys Vlasenko
2012-09-24 11:27   ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343971271-13355-4-git-send-email-linux@horizon.com \
    --to=linux@horizon.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.