From: lyude@redhat.com
To: sashiko-reviews@lists.linux.dev
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/nouveau/gsp/r535: Add support for INTERNAL_GCX_ENTRY_PREREQUISITE
Date: Tue, 15 Sep 2026 12:42:36 -0400 [thread overview]
Message-ID: <13440da22f31b81af4ac27471ab6d10f1523018f.camel@redhat.com> (raw)
In-Reply-To: <20260911223650.8F0F61F000FF@smtp.kernel.org>
On Fri, 2026-09-11 at 22:36 +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential
> issue(s) to consider:
> - [High] Negative error codes from `nvif_device_gcx_ready()` are
> treated as bitmasks, leading to unpredictable runtime suspend
> behavior.
Probably right
> - [High] Hardcoding `r535_gsp_gcx_ready(gsp)` bypasses the GSP
> function vtable and will cause a NULL pointer dereference on non-RM
> GSPs.
Completely wrong.
> - [Medium] `nvkm_udevice_gcx_ready()` bypasses the ioctl unpack
> protocol and returns a positive bitmask directly as a return code.
I think fine? But unsure if I actually agree with this, if anyone has
any thoughts on this let me know
> - [Low] `GSP_GCX_ENTRY_GC6_READY` and `GSP_GCX_ENTRY_GCOFF_READY` are
> defined but never used.
Correct
next prev parent reply other threads:[~2026-09-15 16:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 21:49 [PATCH 0/5] drm/nouveau/gsp/r570: Follow OpenRM's runtime PM process more closely Lyude Paul
2026-09-11 21:49 ` Lyude Paul
2026-09-11 21:49 ` [PATCH 1/5] drm/nouveau/gsp/r535: Add support for INTERNAL_GCX_ENTRY_PREREQUISITE Lyude Paul
2026-09-11 21:49 ` Lyude Paul
2026-09-11 22:36 ` sashiko-bot
2026-09-15 16:42 ` lyude [this message]
2026-09-11 21:49 ` [PATCH 2/5] drm/nouveau/gsp/r535: Add support for MEMSYS_GET_STATIC_CONFIG Lyude Paul
2026-09-11 21:49 ` Lyude Paul
2026-09-11 22:34 ` sashiko-bot
2026-09-11 21:49 ` [PATCH 3/5] drm/nouveau/gsp/r570: Add comp mode workaround from issue #3172217 Lyude Paul
2026-09-11 21:49 ` Lyude Paul
2026-09-11 22:37 ` sashiko-bot
2026-09-15 17:28 ` lyude
2026-09-11 21:49 ` [PATCH 4/5] drm/nouveau/gsp/r570: Start saving comptag backing stores Lyude Paul
2026-09-11 21:49 ` Lyude Paul
2026-09-11 22:43 ` sashiko-bot
2026-09-11 21:49 ` [PATCH 5/5] drm/nouveau/gsp/r570: Enable Gcoff in fbsr again Lyude Paul
2026-09-11 21:49 ` Lyude Paul
2026-09-11 22:49 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13440da22f31b81af4ac27471ab6d10f1523018f.camel@redhat.com \
--to=lyude@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.