From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
Eric Dumazet <edumazet@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Joe Perches <joe@perches.com>,
Neil Horman <nhorman@tuxdriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup()
Date: Mon, 06 Aug 2012 20:31:46 +0800 [thread overview]
Message-ID: <1344256306.14728.29.camel@cr0> (raw)
In-Reply-To: <1344246244.26674.0.camel@edumazet-glaptop>
On Mon, 2012-08-06 at 11:44 +0200, Eric Dumazet wrote:
> On Mon, 2012-08-06 at 17:08 +0800, Cong Wang wrote:
> > On Fri, 2012-08-03 at 12:10 +0200, Eric Dumazet wrote:
> > >
> > > I did this , just take it ;)
> >
> > Do we have to pass gfp to ->ndo_netpoll_setup() too? It seems no, so far
> > I don't think we have to do that.
> >
> > Thanks.
> >
>
> It is needed.
>
> ->ndo_netpoll_setup() is called from __netpoll_setup()
>
> So it would make no sense to allow GFP_KERNEL allocations in
> ndo_netpoll_setup() hgandlers if we called __netpoll_setup() with
> GFP_ATOMIC gfp
>
I see your point. Thanks!
next prev parent reply other threads:[~2012-08-06 12:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 15:37 [PATCH 0/7] netpoll and netconsole fixes for 3.6 Cong Wang
2012-07-27 15:37 ` [PATCH 1/7] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup() Cong Wang
2012-08-03 9:17 ` Eric Dumazet
2012-08-03 9:34 ` Cong Wang
2012-08-03 10:10 ` Eric Dumazet
2012-08-06 9:08 ` Cong Wang
2012-08-06 9:44 ` Eric Dumazet
2012-08-06 12:31 ` Cong Wang [this message]
2012-07-27 15:37 ` [Bridge] [PATCH 2/7] netpoll: make __netpoll_cleanup non-block Cong Wang
2012-07-27 15:37 ` Cong Wang
2012-07-27 15:37 ` Cong Wang
2012-07-27 18:40 ` Neil Horman
2012-07-27 18:40 ` [Bridge] " Neil Horman
2012-07-30 1:42 ` Cong Wang
2012-07-30 1:42 ` Cong Wang
2012-07-30 1:42 ` Cong Wang
2012-07-27 15:38 ` [PATCH 3/7] netconsole: do not release spin_lock before calling __netpoll_cleanup Cong Wang
2012-07-27 15:38 ` [Bridge] [PATCH 4/7] bridge: call NETDEV_RELEASE notifier in br_del_if() Cong Wang
2012-07-27 15:38 ` Cong Wang
2012-07-27 15:50 ` [Bridge] " Stephen Hemminger
2012-07-27 15:50 ` Stephen Hemminger
2012-07-27 15:50 ` Stephen Hemminger
2012-07-30 1:59 ` [Bridge] " Cong Wang
2012-07-30 1:59 ` Cong Wang
2012-07-30 1:59 ` Cong Wang
2012-07-27 15:38 ` [PATCH 5/7] netpoll: take rcu_read_lock_bh() in netpoll_rx() Cong Wang
2012-07-27 15:38 ` [PATCH 6/7] netpoll: use netpoll_rx_on() " Cong Wang
2012-07-27 15:38 ` [PATCH 7/7] netpoll: take rcu_read_lock_bh() in netpoll_send_skb_on_dev() Cong Wang
2012-08-01 2:22 ` [PATCH 0/7] netpoll and netconsole fixes for 3.6 Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344256306.14728.29.camel@cr0 \
--to=amwang@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.