From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched,cgroup_sched: fix up task_groups list
Date: Mon, 06 Aug 2012 22:41:28 +0200 [thread overview]
Message-ID: <1344285688.27828.114.camel@twins> (raw)
In-Reply-To: <1344283776.6768.10.camel@marge.simpson.net>
On Mon, 2012-08-06 at 22:09 +0200, Mike Galbraith wrote:
> On Mon, 2012-08-06 at 21:04 +0200, Peter Zijlstra wrote:
> > On Mon, 2012-08-06 at 17:32 +0200, Mike Galbraith wrote:
> > > Thinko happened during sched migration to kernel/sched, fix it up.
> >
> > what's the effect.. that is what broke and why are we backporting this
> > to -stable?
>
> The effect is that for_each_rt_rq() doesn't work, because it's not the
> same task_groups list that groups were added to, it's an empty list, so
> __enable/disable_runtime() and print_rt_stats() don't work, and you
> can't see rt task groups.
It seems to me this makes for excellent changelog material ;-)
next prev parent reply other threads:[~2012-08-06 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 15:32 [patch] sched,cgroup_sched: fix up task_groups list Mike Galbraith
2012-08-06 19:04 ` Peter Zijlstra
2012-08-06 20:09 ` Mike Galbraith
2012-08-06 20:41 ` Peter Zijlstra [this message]
2012-08-07 3:00 ` Mike Galbraith
2012-08-13 16:51 ` [tip:sched/urgent] sched,cgroup: Fix " tip-bot for Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344285688.27828.114.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.