From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fixup desired rps frequency computation Date: Wed, 08 Aug 2012 21:12:21 +0100 Message-ID: <1344456739_60463@CP5-2952> References: <1344440572-12411-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 893D09E828 for ; Wed, 8 Aug 2012 13:12:27 -0700 (PDT) In-Reply-To: <1344440572-12411-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, 8 Aug 2012 17:42:52 +0200, Daniel Vetter wrote: > In commit > > commit 20b46e59dd102665ce7168baa215e5b1ee66b69b > Author: Daniel Vetter > Date: Thu Jul 26 11:16:14 2012 +0200 > > drm/i915: Only set the down rps limit when at the loweset frequency > > The computation for the new desired frequency was extracted, but since > the desired frequency was passed-by value, the adjustments didn't > propgate back. Fix this. > > Signed-off-by: Daniel Vetter Ouch, how embarrassing - for the reviewer. :( Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre