From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 0/8] rps locking fixes v2
Date: Thu, 09 Aug 2012 10:43:53 +0100 [thread overview]
Message-ID: <1344505436_63070@CP5-2952> (raw)
In-Reply-To: <1344461740-1231-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 8 Aug 2012 23:35:32 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Hi all,
>
> Essentially just rebase, with Ben's review comments taking into account and one
> WARN_ON(mutex_is_locked) moved around a bit.
>
> Review&testing highly welcome.
>
> Cheers, Daniel
>
> Daniel Vetter (8):
> drm/i915: properly guard ilk ips state
> drm/i915: fixup up debugfs rps state handling
> drm/i915: move all rps state into dev_priv->rps
> drm/i915: kill dev_priv->mchdev_lock
> drm/i915: DE_PCU_EVENT irq is ilk-only
> drm/i915: fix up ilk drps/ips locking
> drm/ips: move drps/ips/ilk related variables into dev_priv->ips
1-7 look like good mechanical changes to improve readability and remove
some superstition (multiple igfx perchance). Only the single comment,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> drm/i915: enable rc6 on ilk again
Optimist.
I think you need an ack from the guilty parties if they believe that
the code is in good order first.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-08-09 9:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 21:35 [PATCH 0/8] rps locking fixes v2 Daniel Vetter
2012-08-08 21:35 ` [PATCH 1/8] drm/i915: properly guard ilk ips state Daniel Vetter
2012-08-09 14:44 ` [PATCH] " Daniel Vetter
2012-08-08 21:35 ` [PATCH 2/8] drm/i915: fixup up debugfs rps state handling Daniel Vetter
2012-08-09 9:32 ` Chris Wilson
2012-08-09 13:07 ` [PATCH 1/2] " Daniel Vetter
2012-08-09 13:07 ` [PATCH 2/2] drm/i915: use mutex_lock_interruptible for debugfs files Daniel Vetter
2012-08-09 20:18 ` Ben Widawsky
2012-08-08 21:35 ` [PATCH 3/8] drm/i915: move all rps state into dev_priv->rps Daniel Vetter
2012-08-08 21:35 ` [PATCH 4/8] drm/i915: kill dev_priv->mchdev_lock Daniel Vetter
2012-08-08 21:35 ` [PATCH 5/8] drm/i915: DE_PCU_EVENT irq is ilk-only Daniel Vetter
2012-08-08 21:35 ` [PATCH 6/8] drm/i915: fix up ilk drps/ips locking Daniel Vetter
2012-08-09 14:46 ` [PATCH] " Daniel Vetter
2012-08-08 21:35 ` [PATCH 7/8] drm/ips: move drps/ips/ilk related variables into dev_priv->ips Daniel Vetter
2012-08-28 16:14 ` Daniel Vetter
2012-08-08 21:35 ` [PATCH 8/8] drm/i915: enable rc6 on ilk again Daniel Vetter
2012-08-09 20:26 ` Ben Widawsky
2012-08-09 9:43 ` Chris Wilson [this message]
2012-08-09 11:48 ` [PATCH 0/8] rps locking fixes v2 Daniel Vetter
2012-08-09 14:58 ` Lespiau, Damien
2012-08-09 20:36 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344505436_63070@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.