From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 4/4] drm/i915: Cleanup instdone state when idle
Date: Tue, 14 Aug 2012 08:39:05 +0100 [thread overview]
Message-ID: <1344929956_90118@CP5-2952> (raw)
In-Reply-To: <1344922871-2248-4-git-send-email-ben@bwidawsk.net>
On Mon, 13 Aug 2012 22:41:11 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> The previous state is bogus when we've gone into idle. Actually there
> would be a known state of idle (ie. all units are done), but since it
> differs for every platform, we can just set 0, and let the hangcheck
> progress as normal.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=52429
> Tested-by: Guang A Yang <guang.a.yang@intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
I think you have a point, but I don't think this should be just on idle.
Everytime we kick off the hangcheck, we should not be comparing to stale
state.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-08-14 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 5:41 [PATCH 1/4] drm/i915/contexts: fix list corruption Ben Widawsky
2012-08-14 5:41 ` [PATCH 2/4] drm/i915/contexts: Add forced switches Ben Widawsky
2012-08-14 5:41 ` [PATCH 3/4] drm/i915/contexts: Serialize default context init Ben Widawsky
2012-08-14 7:41 ` Chris Wilson
2012-08-14 16:41 ` Ben Widawsky
2012-08-14 5:41 ` [PATCH 4/4] drm/i915: Cleanup instdone state when idle Ben Widawsky
2012-08-14 7:39 ` Chris Wilson [this message]
2012-08-14 16:42 ` Ben Widawsky
2012-08-14 16:48 ` Chris Wilson
2012-08-14 7:36 ` [PATCH 1/4] drm/i915/contexts: fix list corruption Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344929956_90118@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.