Re: [PATCH] knotty: Fold knotty2 into knotty and make it the default

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2012-08-15 at 11:56 -0500, Jason Wessel wrote:
> On 08/15/2012 11:50 AM, Richard Purdie wrote:
> > There is no good reason knotty2 shouldn't be the default now. If you need
> > the old behaviour, just pipe the output through cat as non-interactive
> > terminals get the old output.
> 
> 
> I didn't look at this in much detail to see if it is was a direct fold or if you made changes along the way.
> 
> I have a whole series of patches outstanding against knotty2 for
> fixing its behavior for the very annoying line wrapping problems and
> the like.  Certainly I can rebase the work done to this end, but these
> problems need to be addressed, preferably before you make this the
> default.

Have a look at the preceding patches ;-)

I've fixed the line wrapping and window resizing issues first. It was
based on some of your changes but I fixed various things (like having
progressbar chain the WINCH signal handlers instead of hacking around
it).

This doesn't add the interactive logging as I'm still not sure that
makes sense in master. If we do that I want to think more carefully
about the UI to it.

The interactive terminal stuff is also pending as I was pretty horrified
when I realised how you implemented it. What we need to do is issue an
event and have bitbake respond to that event where the event contains a
"command" parameter.

So I'm working through the patches but I think with the changes I just
posted, knotty2 should be ready for wider usage.

Cheers,

Richard