From: Chris Wilson <chris@chris-wilson.co.uk>
To: Damien Lespiau <damien.lespiau@gmail.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't hardcode the number of pipes in the error state dump
Date: Wed, 15 Aug 2012 19:42:15 +0100 [thread overview]
Message-ID: <1345056147_100284@CP5-2952> (raw)
In-Reply-To: <1345055005-23850-1-git-send-email-damien.lespiau@gmail.com>
On Wed, 15 Aug 2012 19:23:25 +0100, Damien Lespiau <damien.lespiau@gmail.com> wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
> for_each_pipe() macro and make struct intel_display_error_state is big
> enough.
>
> V2: Also add the number of pipes emitted (Chris Wilson)
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
I guess next on your list will be adding some of the PCH register
states, along with a list of active encoders / connectors etc.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-08-15 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 18:23 [PATCH] drm/i915: Don't hardcode the number of pipes in the error state dump Damien Lespiau
2012-08-15 18:42 ` Chris Wilson [this message]
2012-08-15 22:40 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2012-08-15 16:57 Damien Lespiau
2012-08-15 17:00 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345056147_100284@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=damien.lespiau@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.