From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754622Ab2HPROb (ORCPT ); Thu, 16 Aug 2012 13:14:31 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:57679 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338Ab2HPROa (ORCPT ); Thu, 16 Aug 2012 13:14:30 -0400 From: Will Deacon To: linux-kernel@vger.kernel.org Cc: Will Deacon , Jason Baron , Wade Farnsworth , Steven Rostedt , Frederic Weisbecker Subject: [PATCH] tracing/syscalls: fix perf syscall tracing when syscall_nr == -1 Date: Thu, 16 Aug 2012 18:14:14 +0100 Message-Id: <1345137254-7377-1-git-send-email-will.deacon@arm.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org syscall_get_nr can return -1 in the case that the task is not executing a system call. This patch fixes perf_syscall_{enter,exit} to check that the syscall number is valid before using it as an index into a bitmap. Cc: Jason Baron Cc: Wade Farnsworth Cc: Steven Rostedt Cc: Frederic Weisbecker Signed-off-by: Will Deacon --- kernel/trace/trace_syscalls.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c index 96fc733..4bc7d92 100644 --- a/kernel/trace/trace_syscalls.c +++ b/kernel/trace/trace_syscalls.c @@ -506,6 +506,8 @@ static void perf_syscall_enter(void *ignore, struct pt_regs *regs, long id) int size; syscall_nr = syscall_get_nr(current, regs); + if (syscall_nr < 0) + return; if (!test_bit(syscall_nr, enabled_perf_enter_syscalls)) return; @@ -580,6 +582,8 @@ static void perf_syscall_exit(void *ignore, struct pt_regs *regs, long ret) int size; syscall_nr = syscall_get_nr(current, regs); + if (syscall_nr < 0) + return; if (!test_bit(syscall_nr, enabled_perf_exit_syscalls)) return; -- 1.7.4.1