From: Artem Bityutskiy <dedekind1@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
David.Woodhouse@intel.com, ben-linux@fluff.org,
patches@linaro.org
Subject: Re: [PATCH 2/6] mtd: s3c2410: Use pr_* instead of printk
Date: Sun, 19 Aug 2012 14:07:27 +0300 [thread overview]
Message-ID: <1345374447.1832.1.camel@kyv> (raw)
In-Reply-To: <1342434747-27622-2-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On Mon, 2012-07-16 at 16:02 +0530, Sachin Kamat wrote:
> #ifdef CONFIG_MTD_NAND_S3C2410_DEBUG
> #define DEBUG
> #endif
> @@ -215,7 +217,8 @@ static int s3c_nand_calc_rate(int wanted, unsigned long clk, int max)
> pr_debug("result %d from %ld, %d\n", result, clk, wanted);
>
> if (result > max) {
> - printk("%d ns is too big for current clock rate %ld\n", wanted, clk);
> + pr_err("%d ns is too big for current clock rate %ld\n",
> + wanted, clk);
I've removed tabs to make "wanted" more aligned with where the format
string starts, and pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-19 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 10:32 [PATCH 1/6] mtd: s3c2410: Use module_platform_driver() Sachin Kamat
2012-07-16 10:32 ` [PATCH 2/6] mtd: s3c2410: Use pr_* instead of printk Sachin Kamat
2012-08-19 11:07 ` Artem Bityutskiy [this message]
2012-07-16 10:32 ` [PATCH 3/6] mtd: s3c2410: Use <linux/io.h> instead of <asm/io.h> Sachin Kamat
2012-07-16 10:32 ` [PATCH 4/6] mtd: s3c2410: Do not initialise statics to 0 or NULL Sachin Kamat
2012-07-16 10:32 ` [PATCH 5/6] mtd: s3c2410: Fix checkpatch warnings and errors related to whitespaces Sachin Kamat
2012-08-19 11:08 ` Artem Bityutskiy
2012-07-16 10:32 ` [PATCH 6/6] mtd: s3c2410: Fix line over 80 characters warning Sachin Kamat
2012-08-19 11:11 ` Artem Bityutskiy
2012-08-21 4:51 ` Sachin Kamat
2012-08-03 4:47 ` [PATCH 1/6] mtd: s3c2410: Use module_platform_driver() Sachin Kamat
2012-08-08 9:30 ` Sachin Kamat
2012-08-16 5:23 ` Sachin Kamat
2012-08-17 12:46 ` Artem Bityutskiy
2012-08-18 6:21 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345374447.1832.1.camel@kyv \
--to=dedekind1@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=ben-linux@fluff.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.