From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com,
blauwirbel@gmail.com, anthony@codemonkey.ws, pbonzini@redhat.com,
eblake@redhat.com, afaerber@suse.de,
"Benoît Canet" <benoit@irqsave.net>
Subject: [Qemu-devel] [RFC V4 7/9] quorum: Add quorum_aio_readv.
Date: Mon, 20 Aug 2012 13:48:01 +0200 [thread overview]
Message-ID: <1345463283-9684-8-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1345463283-9684-1-git-send-email-benoit@irqsave.net>
Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
block/quorum.c | 38 +++++++++++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/block/quorum.c b/block/quorum.c
index 092d1ea..95f4668 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -180,15 +180,24 @@ static void quorum_aio_bh(void *opaque)
{
QuorumAIOCB *acb = opaque;
BDRVQuorumState *s = acb->bqs;
- int ret;
+ int i, ret;
ret = s->threshold <= acb->success_count ? 0 : -EIO;
+ for (i = 0; i < s->total; i++) {
+ qemu_vfree(acb->aios[i].buf);
+ acb->aios[i].buf = NULL;
+ acb->aios[i].ret = 0;
+ }
+
qemu_bh_delete(acb->bh);
acb->common.cb(acb->common.opaque, ret);
if (acb->finished) {
*acb->finished = true;
}
+ for (i = 0; i < s->total; i++) {
+ qemu_iovec_destroy(&acb->qiovs[i]);
+ }
g_free(acb->aios);
g_free(acb->qiovs);
qemu_aio_release(acb);
@@ -248,6 +257,32 @@ static void quorum_aio_cb(void *opaque, int ret)
qemu_bh_schedule(acb->bh);
}
+static BlockDriverAIOCB *quorum_aio_readv(BlockDriverState *bs,
+ int64_t sector_num,
+ QEMUIOVector *qiov,
+ int nb_sectors,
+ BlockDriverCompletionFunc *cb,
+ void *opaque)
+{
+ BDRVQuorumState *s = bs->opaque;
+ QuorumAIOCB *acb = quorum_aio_get(s, bs, qiov, sector_num,
+ nb_sectors, cb, opaque);
+ int i;
+
+ for (i = 0; i < s->total; i++) {
+ acb->aios[i].buf = qemu_blockalign(bs->file, qiov->size);
+ qemu_iovec_init(&acb->qiovs[i], qiov->niov);
+ qemu_iovec_clone(&acb->qiovs[i], qiov, acb->aios[i].buf);
+ }
+
+ for (i = 0; i < s->total; i++) {
+ bdrv_aio_readv(s->bs[i], sector_num, qiov, nb_sectors,
+ quorum_aio_cb, &acb->aios[i]);
+ }
+
+ return &acb->common;
+}
+
static BlockDriverAIOCB *quorum_aio_writev(BlockDriverState *bs,
int64_t sector_num,
QEMUIOVector *qiov,
@@ -291,6 +326,7 @@ static BlockDriver bdrv_quorum = {
.bdrv_close = quorum_close,
.bdrv_co_flush_to_disk = quorum_co_flush,
+ .bdrv_aio_readv = quorum_aio_readv,
.bdrv_aio_writev = quorum_aio_writev,
};
--
1.7.9.5
next prev parent reply other threads:[~2012-08-20 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 11:47 [Qemu-devel] [RFC V4 0/9] Quorum disk image corruption resiliency Benoît Canet
2012-08-20 11:47 ` [Qemu-devel] [RFC V4 1/9] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2012-08-20 11:47 ` [Qemu-devel] [RFC V4 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2012-08-20 11:47 ` [Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close() Benoît Canet
2012-08-20 19:47 ` Blue Swirl
2012-08-20 20:37 ` Eric Blake
2012-08-21 10:13 ` Benoît Canet
2012-08-20 11:47 ` [Qemu-devel] [RFC V4 4/9] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2012-08-20 11:47 ` [Qemu-devel] [RFC V4 5/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2012-08-20 11:48 ` [Qemu-devel] [RFC V4 6/9] quorum: Add quorum_co_flush() Benoît Canet
2012-08-20 11:48 ` Benoît Canet [this message]
2012-08-20 11:48 ` [Qemu-devel] [RFC V4 8/9] quorum: Add quorum mechanism Benoît Canet
2012-08-20 11:48 ` [Qemu-devel] [RFC V4 9/9] quorum: Add quorum_getlength() Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345463283-9684-8-git-send-email-benoit@irqsave.net \
--to=benoit.canet@gmail.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=benoit@irqsave.net \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.