From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] Tegra 2 USB ULPI series
Date: Mon, 20 Aug 2012 21:59:33 +0200 [thread overview]
Message-ID: <1345492773.6188.5.camel@selen> (raw)
In-Reply-To: <50327D70.5030504@wwwdotorg.org>
Am Montag, den 20.08.2012, 12:09 -0600 schrieb Stephen Warren:
> On 08/19/2012 10:08 AM, Lucas Stach wrote:
> > With this series we are able to initialize USB controllers
> > using an external ULPI phy AKA USB2 on Tegra 2 devices.
> >
> > This was tested to work on a Toradex Colibri T20 board,
> > where USB2 is used to access the ASIX ethernet chipset.
> > Testing was done with "tegra20: usb: rework set_host_mode"
> > applied. I did not spot any regressions on the UTMI ports.
> >
> > Patchset is based on top of u-boot-tegra/next
>
> Hmmm. I tried testing this on my local branch on Harmony, which has all
> the patches necessary for multiple USB ports to work, and indeed they do
> on Seaboard. However, this series (plus some Harmony-specific config and
> .dts changes) didn't cause the ULPI port to work:-( Any idea why?
>
Could you try the attached hack and report back? If it doesn't help
please build with DEBUG defined in
arch/arm/cpu/armv7/tegra20/usb.c
drivers/usb/host/ehci-hcd.c
and provide me the output of the usb start command.
Thanks,
Lucas
diff --git a/arch/arm/cpu/armv7/tegra20/usb.c b/arch/arm/cpu/armv7/tegra20/usb.c
index 2ae1244..4c85685 100644
--- a/arch/arm/cpu/armv7/tegra20/usb.c
+++ b/arch/arm/cpu/armv7/tegra20/usb.c
@@ -367,7 +367,7 @@ static int init_ulpi_usb_controller(struct fdt_usb *config,
}
ulpi_write(&ulpi_vp, &ulpi_reg->iface_ctrl_set, ULPI_IFACE_PASSTHRU);
- ulpi_write(&ulpi_vp, &ulpi_reg->otg_ctrl_set, ULPI_OTG_EXTVBUSIND);
+ ulpi_write(&ulpi_vp, &ulpi_reg->otg_ctrl_set, ULPI_OTG_DRVVBUS|ULPI_OTG_DRVVBUS_EXT|ULPI_OTG_EXTVBUSIND);
/* enable wakeup events */
setbits_le32(&usbctlr->port_sc1, WKCN | WKDS | WKOC);
next prev parent reply other threads:[~2012-08-20 19:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 16:08 [U-Boot] [PATCH 0/3] Tegra 2 USB ULPI series Lucas Stach
2012-08-19 16:08 ` [U-Boot] [PATCH 1/3] tegra20: complete periph_id enum Lucas Stach
2012-08-20 18:12 ` Stephen Warren
2012-08-21 19:04 ` Simon Glass
2012-08-19 16:08 ` [U-Boot] [PATCH 2/3] tegra20: add clock_set_pllout function Lucas Stach
2012-08-20 18:19 ` Stephen Warren
2012-08-19 16:08 ` [U-Boot] [PATCH 3/3] tegra20: add USB ULPI init code Lucas Stach
2012-08-20 12:07 ` Igor Grinberg
2012-08-20 12:41 ` Lucas Stach
2012-08-20 18:27 ` Stephen Warren
2012-08-21 7:59 ` Igor Grinberg
2012-08-21 7:54 ` Igor Grinberg
2012-08-20 18:25 ` Stephen Warren
2012-08-20 12:27 ` [U-Boot] [PATCH 0/3] Tegra 2 USB ULPI series Igor Grinberg
2012-08-20 12:43 ` Lucas Stach
2012-08-20 18:09 ` Stephen Warren
2012-08-20 19:59 ` Lucas Stach [this message]
2012-08-22 16:06 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345492773.6188.5.camel@selen \
--to=dev@lynxeye.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.