Re: [RFC] gatchat: Print error message if opening tun failes

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

Hi Daniel,

> This is a very common misstake. Let's help the users to
> configure their system correctly.
> ---
>  gatchat/ppp_net.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/gatchat/ppp_net.c b/gatchat/ppp_net.c
> index 1609b99..7082de7 100644
> --- a/gatchat/ppp_net.c
> +++ b/gatchat/ppp_net.c
> @@ -155,8 +155,12 @@ struct ppp_net *ppp_net_new(GAtPPP *ppp, int fd)
>  	if (fd < 0) {
>  		/* open a tun interface */
>  		fd = open("/dev/net/tun", O_RDWR);
> -		if (fd < 0)
> +		if (fd < 0) {
> +			fprintf(stderr, "Couldn't open tun device. "
> +					"Do you run oFono as root and do you "
> +					"have the TUN module loaded?");

really, stderr?

>  			goto error;
> +		}
>  
>  		ifr.ifr_flags = IFF_TUN | IFF_NO_PI;
>  		strcpy(ifr.ifr_name, "ppp%d");

Aren't the atom drivers checking this case for you?

Regards

Marcel