Re: [PATCH v3 4/6] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

[Artem Bityutskiy <dedekind1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

Amended the commit subject,

On Mon, 2012-08-20 at 18:00 +0200, Richard Genoud wrote:
> This patch provides the possibility to adjust the "maximum expected number of
> bad blocks per 1024 blocks" (max_beb_per1024) for each mtd device.
> 
> The majority of NAND devices have their max_beb_per1024 equal to 20, but
> sometimes it's more.
> Now, we can adjust that via a kernel parameter:
> ubi.mtd=<name|num|path>[,<vid_hdr_offs>[,max_beb_per1024]]
> 
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>

Did few minor amendments and applied this one. And pushed out. 

> +			pr_err("UBI error: bad value for max_beb_per1024 parameter: %s",
> +			       tokens[2]);

Changed this to 'printk(KERN_ERR' and wrapped the line.

The former is because the entire function uses 'printk(KERN_ERR', and I
am a fan of consistency. We can change them all to 'pr_err()' and
'pr_warn()' in a separate patch.

Similar for wrapping - UBI wraps all messages. If we want, we can unwrap
them all in a separate patch.

Feel free to submit such a patch, I won't have objections.

> -MODULE_PARM_DESC(mtd, "MTD devices to attach. Parameter format: "
> -		      "mtd=<name|num|path>[,<vid_hdr_offs>].\n"

You unwrapped this one and I pushed that as is, because it is just much
more readable, and it is the only place where we describe a module, so
no inconsistencies. :-)

Thank you!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]