From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237]
	helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <richard.purdie@linuxfoundation.org>)
	id 1T4AgE-0008P4-R8 for bitbake-devel@lists.openembedded.org;
	Wed, 22 Aug 2012 15:09:07 +0200
Received: from localhost (localhost [127.0.0.1])
	by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q7MCv2ih003221;
	Wed, 22 Aug 2012 13:57:02 +0100
Received: from tim.rpsys.net ([127.0.0.1])
	by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new,
	port 10024) with LMTP
	id 02380-09; Wed, 22 Aug 2012 13:56:58 +0100 (BST)
Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0)
	by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q7MCusV5003211
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
	Wed, 22 Aug 2012 13:56:55 +0100
Message-ID: <1345640215.3907.113.camel@ted>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Date: Wed, 22 Aug 2012 13:56:55 +0100
In-Reply-To: <1345583158-3142-1-git-send-email-mark.hatle@windriver.com>
References: <1345583158-3142-1-git-send-email-mark.hatle@windriver.com>
X-Mailer: Evolution 3.2.3-0ubuntu6 
Mime-Version: 1.0
X-Virus-Scanned: amavisd-new at rpsys.net
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] ui: Improve error message if bitbake cannot import python curses module
X-BeenThere: bitbake-devel@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <bitbake-devel.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/bitbake-devel>,
	<mailto:bitbake-devel-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/bitbake-devel>
List-Post: <mailto:bitbake-devel@lists.openembedded.org>
List-Help: <mailto:bitbake-devel-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel>,
	<mailto:bitbake-devel-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Aug 2012 13:09:07 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Tue, 2012-08-21 at 16:05 -0500, Mark Hatle wrote:
> From: Konrad Scherer <Konrad.Scherer@windriver.com>
> 
> On some SuSE systems, the curses python module is not installed by default.
> Instead of a python failure, we want a nicer error message.
> 
> (On SuSE systems the package is typically python-curses.)
> 
> Signed-off-by: Konrad Scherer <Konrad.Scherer@windriver.com>
> Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
> 
> Reword commit message, rebase to latest bitbake.
> 
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> ---
>  lib/bb/ui/knotty.py  |    6 +++++-
>  lib/bb/ui/ncurses.py |    8 +++++++-
>  2 files changed, 12 insertions(+), 2 deletions(-)

Thanks, merged to master.

I did wonder if this shouldn't just print a warning and proceed as if
the terminal were non-interactive though. Regardless, this improves the
situation.

Cheers,

Richard