From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 27/29] drm/i915: Allocate overlay registers from stolen memory Date: Wed, 22 Aug 2012 16:45:45 +0100 Message-ID: <1345650352_1866@CP5-2952> References: <1344696088-24760-1-git-send-email-chris@chris-wilson.co.uk> <1344696088-24760-28-git-send-email-chris@chris-wilson.co.uk> <20120820211706.GI5170@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id CC9779E78E for ; Wed, 22 Aug 2012 08:45:57 -0700 (PDT) In-Reply-To: <20120820211706.GI5170@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 20 Aug 2012 23:17:06 +0200, Daniel Vetter wrote: > On Sat, Aug 11, 2012 at 03:41:26PM +0100, Chris Wilson wrote: > > Signed-off-by: Chris Wilson > > Since most of the overlay-supporting hw uses physical mem for the overlay > I think this isn't much worth it: The additional frobbery in > attach/detach_phys object is likely more work than we'll anything we'll > ever gain from using stolen mem here. Especially since we'll use stolen > mem already for the rings. In a straw poll of the machines on my desk, non-physical machines outnumber the physical overlay machines. :-p However, hooking up the physical to use stolen is also a good idea. Too bad, I haven't found a way to detect the base of stolen memory on gen2 devices without arch specific internals. It worked nicely right up until I tried to build i915.ko as a module. -Chris -- Chris Wilson, Intel Open Source Technology Centre