From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 18/29] drm/i915: Delay allocation of stolen space for FBC Date: Wed, 22 Aug 2012 16:51:34 +0100 Message-ID: <1345650701_1885@CP5-2952> References: <1344696088-24760-1-git-send-email-chris@chris-wilson.co.uk> <1344696088-24760-19-git-send-email-chris@chris-wilson.co.uk> <20120820195142.GG5170@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 15B5E9E7DD for ; Wed, 22 Aug 2012 08:51:45 -0700 (PDT) In-Reply-To: <20120820195142.GG5170@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 20 Aug 2012 21:51:42 +0200, Daniel Vetter wrote: > On Sat, Aug 11, 2012 at 03:41:17PM +0100, Chris Wilson wrote: > > As we may wish to wrap regions preallocated by the BIOS, we need to do > > that before carving out contiguous chunks of stolen space for FBC. > > > > Signed-off-by: Chris Wilson > > Some comments inline below. I split the pm chunk into its own commit for a standalone justitication (do not allocate stolen until we need FBC). The drm_mm_for_each_hole merits a slightly bigger patch, as there is a couple of sites in drm_mm.c that can take advantage of it and so will be a good test of its palatability. -Chris -- Chris Wilson, Intel Open Source Technology Centre