All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: autotest-kernel@redhat.com
Cc: kvm@vger.kernel.org, Lucas Meneghel Rodrigues <lmr@redhat.com>,
	Amos Kong <akong@redhat.com>
Subject: [PATCH] virt.netperf: Use ssh_key lib rather than off limits server lib
Date: Wed, 22 Aug 2012 14:24:25 -0300	[thread overview]
Message-ID: <1345656265-11081-1-git-send-email-lmr@redhat.com> (raw)

When running the kvm autotest tests on a given host through
the autotest server, it's important to remember that only
the autotest client is copied to machines, making anything
that is not on the autotest.client namespace *off-limits*.

So, replace usage of SSHHost server class (here used only
to get ssh key setup) to use the ssh_key module, recently
split out due to a similar mistake made by test authors.

CC: Amos Kong <akong@redhat.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
 client/virt/tests/netperf.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/client/virt/tests/netperf.py b/client/virt/tests/netperf.py
index c054c10..e137d45 100644
--- a/client/virt/tests/netperf.py
+++ b/client/virt/tests/netperf.py
@@ -1,6 +1,6 @@
 import logging, os, commands, threading, re, glob
-from autotest.server.hosts.ssh_host import SSHHost
 from autotest.client import utils
+from autotest.client.shared import ssh_key
 from autotest.client.virt import utils_test, utils_misc, remote
 
 
@@ -60,7 +60,8 @@ def run_netperf(test, params, env):
 
     def env_setup(ip):
         logging.debug("Setup env for %s" % ip)
-        SSHHost(ip, user=username, port=shell_port, password=password)
+        ssh_key.setup_ssh_key(hostname=ip, user=username, port=shell_port,
+                              password=password)
         ssh_cmd(ip, "service iptables stop")
         ssh_cmd(ip, "echo 1 > /proc/sys/net/ipv4/conf/all/arp_ignore")
 
-- 
1.7.11.4


                 reply	other threads:[~2012-08-22 17:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345656265-11081-1-git-send-email-lmr@redhat.com \
    --to=lmr@redhat.com \
    --cc=akong@redhat.com \
    --cc=autotest-kernel@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.