From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Debabrata Banerjee <dbavatar@gmail.com>,
netdev@vger.kernel.org, "Banerjee,
Debabrata" <dbanerje@akamai.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 1/2] ipv6: do not hold route table lock when send ndisc probe
Date: Fri, 24 Aug 2012 18:45:40 +0800 [thread overview]
Message-ID: <1345805140.9305.1.camel@cr0> (raw)
In-Reply-To: <1345801484.29722.2.camel@edumazet-glaptop>
On Fri, 2012-08-24 at 11:44 +0200, Eric Dumazet wrote:
> On Fri, 2012-08-24 at 17:15 +0800, Cong Wang wrote:
>
> >
> > Right... If we call dev_hold() in the work, it is possible that the work
> > is still not scheduled to running when we unregister the device. What's
> > more, we can't flush work here as we are holding a read lock.
>
> You need a global list (and a single work, not one per req), so that a
> notifier can flush it at demand.
>
>
Agreed. I will make a new patch.
Thanks!
prev parent reply other threads:[~2012-08-24 10:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 7:11 [PATCH 1/2] ipv6: do not hold route table lock when send ndisc probe Cong Wang
2012-08-17 7:11 ` [PATCH 2/2] ipv6: remove some useless RCU read lock Cong Wang
2012-08-17 18:54 ` [PATCH 1/2] ipv6: do not hold route table lock when send ndisc probe Debabrata Banerjee
2012-08-20 12:15 ` Cong Wang
2012-08-21 3:44 ` Cong Wang
2012-08-22 16:04 ` Banerjee, Debabrata
2012-08-23 9:11 ` Cong Wang
2012-08-23 16:10 ` Eric Dumazet
2012-08-24 9:15 ` Cong Wang
2012-08-24 9:44 ` Eric Dumazet
2012-08-24 10:45 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345805140.9305.1.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dbanerje@akamai.com \
--cc=dbavatar@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.