From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: do explicit unaligned accesses
Date: Fri, 31 Aug 2012 11:00:50 +0200 [thread overview]
Message-ID: <1346403650.2252.14.camel@tellur> (raw)
In-Reply-To: <593AEF6C47F46446852B067021A273D660BA94A5@MUCSE039.lantiq.com>
Hi Thomas,
Am Freitag, den 31.08.2012, 08:57 +0000 schrieb Langer Thomas (LQDE RD
ST PON SW):
> Hello Lucas,
>
> > @@ -304,8 +306,9 @@ static int usb_hub_configure(struct usb_device *dev)
> > }
> > memcpy((unsigned char *)&hub->desc, buffer, descriptor->bLength);
> > /* adjust 16bit values */
> > - hub->desc.wHubCharacteristics =
> > - le16_to_cpu(descriptor->wHubCharacteristics);
> > + put_unaligned(le16_to_cpu(get_unaligned(
> > + &descriptor->wHubCharacteristics)),
> > + &descriptor->wHubCharacteristics);
>
> I think, the second parameter should be &hub->... ?
>
Argh, stupid copypasta. Thanks for finding this.
> Best Regards,
> Thomas
>
>
prev parent reply other threads:[~2012-08-31 9:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 23:13 [U-Boot] [PATCH] usb: do explicit unaligned accesses Lucas Stach
2012-08-30 23:29 ` Marek Vasut
2012-08-31 6:08 ` Albert ARIBAUD
2012-08-31 16:15 ` Marek Vasut
[not found] ` <20120831222008.3665fecb@lilith>
2012-08-31 22:16 ` Marek Vasut
2012-09-01 7:12 ` Albert ARIBAUD
[not found] ` <20120901084509.230c7385@lilith>
2012-09-01 14:34 ` Marek Vasut
[not found] ` <20120901170132.7f5cbfb1@lilith>
2012-09-01 15:12 ` Marek Vasut
2012-09-01 16:28 ` Albert ARIBAUD
2012-09-01 16:39 ` Wolfgang Denk
2012-09-01 17:14 ` Marek Vasut
[not found] ` <593AEF6C47F46446852B067021A273D660BA94A5@MUCSE039.lantiq.com>
2012-08-31 9:00 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346403650.2252.14.camel@tellur \
--to=dev@lynxeye.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.