All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lwe@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Jeff Garzik <jgarzik@pobox.com>
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
	Aaron Lu <aaron.lu@intel.com>, Aaron Lu <aaron.lwe@gmail.com>
Subject: [PATCH v6 6/7] scsi: sr: use may_power_off
Date: Tue,  4 Sep 2012 22:24:39 +0800	[thread overview]
Message-ID: <1346768680-7287-7-git-send-email-aaron.lwe@gmail.com> (raw)
In-Reply-To: <1346768680-7287-1-git-send-email-aaron.lwe@gmail.com>

From: Aaron Lu <aaron.lu@intel.com>

With the introduction of may_power_off, when deciding if we can block
events checking, may_power_off should be used.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/scsi/sr.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index a5bb687..291f38c 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -204,7 +204,7 @@ static int sr_suspend(struct device *dev, pm_message_t msg)
 	if (!suspend)
 		return -EBUSY;
 
-	if (cd->device->can_power_off) {
+	if (cd->device->may_power_off) {
 		cd->disk_events_blocked = 1;
 		disk_block_events(cd->disk);
 	}
@@ -794,6 +794,9 @@ static int sr_probe(struct device *dev)
 	sdev_printk(KERN_DEBUG, sdev,
 		    "Attached scsi CD-ROM %s\n", cd->cdi.name);
 
+	if (cd->device->can_power_off)
+		cd->device->may_power_off = 1;
+
 	/* enable runtime pm */
 	scsi_autopm_put_device(cd->device);
 
-- 
1.7.11.3


  parent reply	other threads:[~2012-09-04 14:24 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 14:24 [PATCH v6 0/7] ZPODD patches Aaron Lu
2012-09-04 14:24 ` [PATCH v6 1/7] scsi: sr: support runtime pm for ODD Aaron Lu
2012-09-04 15:57   ` Oliver Neukum
2012-09-04 17:59     ` Alan Stern
2012-09-04 18:47       ` Oliver Neukum
2012-09-05 15:22         ` Aaron Lu
2012-09-05 16:08           ` Alan Stern
2012-09-05 22:49             ` Aaron Lu
2012-09-06 15:06               ` Alan Stern
2012-09-06 15:25                 ` Oliver Neukum
2012-09-06 17:08                   ` Alan Stern
2012-09-06 18:06                     ` Oliver Neukum
2012-09-06 18:50                       ` Alan Stern
2012-09-10  9:16                         ` Aaron Lu
2012-09-10 10:45                           ` Oliver Neukum
2012-09-11  6:44                             ` Aaron Lu
2012-09-11  8:55                               ` Oliver Neukum
2012-09-11  9:24                                 ` Aaron Lu
2012-09-11  9:30                                   ` Oliver Neukum
2012-09-11 11:11                                     ` Aaron Lu
2012-09-11 12:10                                       ` Oliver Neukum
2012-09-11 12:31                                         ` Aaron Lu
2012-09-11 12:35                                           ` Oliver Neukum
2012-09-11 12:13                                     ` Aaron Lu
2012-09-07 14:53                 ` Aaron Lu
2012-09-07 15:41                   ` Alan Stern
2012-09-05 18:06           ` Oliver Neukum
2012-09-06  5:55             ` Aaron Lu
2012-09-06  5:17     ` Aaron Lu
2012-09-04 14:24 ` [PATCH v6 2/7] block: genhd: export disk_(un)block_events Aaron Lu
2012-09-04 14:24 ` [PATCH v6 3/7] scsi: sr: block events checking when suspended for zpodd Aaron Lu
2012-09-04 14:24 ` [PATCH v6 4/7] libata: acpi: set can_power_off for both ODD and HD Aaron Lu
2012-09-07  2:37   ` Jeff Garzik
2012-09-04 14:24 ` [PATCH v6 5/7] scsi: pm: add may_power_off flag Aaron Lu
2012-09-04 16:01   ` Oliver Neukum
2012-09-06  1:52     ` Aaron Lu
2012-09-04 14:24 ` Aaron Lu [this message]
2012-09-04 14:24 ` [PATCH v6 7/7] libata: acpi: respect " Aaron Lu
2012-09-07  2:38   ` Jeff Garzik
2012-09-13  2:42 ` [PATCH v6 0/7] ZPODD patches Jack Wang
2012-09-13  3:20   ` Aaron Lu
2012-09-13  8:15     ` Jack Wang
2012-09-13  8:30       ` Aaron Lu
2012-09-13  8:39         ` Jack Wang
2012-09-13  8:56           ` Aaron Lu
2012-09-13  9:01             ` James Bottomley
2012-09-13  9:12             ` Jack Wang
2012-09-13  9:19               ` [PATCH " Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346768680-7287-7-git-send-email-aaron.lwe@gmail.com \
    --to=aaron.lwe@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=aaron.lu@intel.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.