From: Thomas Monjalon <thomas@monjalon.net>
To: Kai Ji <kai.ji@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
Akhil Goyal <gakhil@marvell.com>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [EXT] Re: [PATCH] crypto/qat: fix build
Date: Wed, 11 Jan 2023 10:03:24 +0100 [thread overview]
Message-ID: <13467772.uLZWGnKmhe@thomas> (raw)
In-Reply-To: <CO6PR18MB4484E7D49720D17250BA054FD8F59@CO6PR18MB4484.namprd18.prod.outlook.com>
04/01/2023 12:56, Akhil Goyal:
> > On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote:
> > > When trying to compile on a fresh system, I hit this error:
> > >
> > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined
> > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE
> > > In file included from drivers/crypto/qat/qat_sym_session.c:8:
> > > /usr/include/openssl/aes.h:26: previous definition
> > > 26 | # define AES_BLOCK_SIZE 16
> > >
> > > I don't know why it was not seen before.
> > > Is it because of a change in intel-ipsec-mb.h or in OpenSSL?
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> >
> > owners of intel-ipsec-mb.h should guard against the namespace
> > conflict...
> >
> > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Applied to dpdk-next-crypto
>
> Thanks.
I'm concerned to have no answer from Pablo and Kai.
It is real design problem. Is there any plan to have a protected namespace?
next prev parent reply other threads:[~2023-01-11 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 21:07 [PATCH] crypto/qat: fix build Thomas Monjalon
2022-12-30 21:38 ` Tyler Retzlaff
2023-01-04 11:56 ` [EXT] " Akhil Goyal
2023-01-11 9:03 ` Thomas Monjalon [this message]
2023-01-11 23:20 ` Thomas Monjalon
2023-01-12 10:32 ` Ji, Kai
2023-01-12 10:40 ` Thomas Monjalon
2023-01-12 13:22 ` De Lara Guarch, Pablo
2023-01-12 15:00 ` Thomas Monjalon
2023-01-12 16:16 ` De Lara Guarch, Pablo
2023-01-12 16:28 ` Thomas Monjalon
2023-01-12 16:56 ` [EXT] " Akhil Goyal
2023-01-12 16:34 ` Tyler Retzlaff
-- strict thread matches above, loose matches on Subject: below --
2023-01-12 19:30 Pablo de Lara
2023-01-12 20:39 ` Thomas Monjalon
2023-01-17 8:22 ` [EXT] " Akhil Goyal
2023-01-18 9:51 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13467772.uLZWGnKmhe@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=kai.ji@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.