From: Joe Perches <joe@perches.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: tony.luck@intel.com, andi@firstfloor.org, bp@amd64.org,
gong.chen@linux.intel.com, ananth@in.ibm.com, x86@kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
tglx@linutronix.de, gregkh@suse.de, linux-edac@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/mce: Pack boolean MCE flags into a structure
Date: Wed, 05 Sep 2012 10:15:22 -0700 [thread overview]
Message-ID: <1346865322.1906.7.camel@joe2Laptop> (raw)
In-Reply-To: <20120905102201.9423.46671.stgit@localhost.localdomain>
On Wed, 2012-09-05 at 15:52 +0530, Naveen N. Rao wrote:
> Many MCE flags are boolean in nature, but are declared as integers
> currently. We can pack these into a bitfield to save some space.
[]
> diff --git a/arch/x86/kernel/cpu/mcheck/mce-internal.h b/arch/x86/kernel/cpu/mcheck/mce-internal.h
[]
> @@ -11,6 +11,15 @@ enum severity_level {
> MCE_PANIC_SEVERITY,
> };
>
> +struct mce_config {
> + __u32 cmci_disabled : 1,
> + ignore_ce : 1,
> + dont_log_ce : 1,
> + __pad : 29;
You don't need to declare __pad
Perhaps bool:1 instead.
next prev parent reply other threads:[~2012-09-05 17:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 10:21 [PATCH 0/3] x86:mce: Some cleanups and bios-set CMCI thresholds Naveen N. Rao
2012-09-05 10:21 ` [PATCH 1/3] x86/mce: Make sysfs tunables available globally across all cpus Naveen N. Rao
2012-09-05 10:32 ` [PATCH] [mcelog] Start using the new sysfs tunables location Naveen N. Rao
2012-09-05 18:47 ` Andi Kleen
2012-09-05 19:09 ` Tony Luck
2012-09-06 6:40 ` Naveen N. Rao
2012-09-06 12:28 ` Andi Kleen
2012-09-06 12:34 ` Naveen N. Rao
2012-09-06 12:51 ` Alan Cox
2012-09-06 13:21 ` Andi Kleen
2012-09-05 10:22 ` [PATCH 2/3] x86/mce: Pack boolean MCE flags into a structure Naveen N. Rao
2012-09-05 17:15 ` Joe Perches [this message]
2012-09-05 18:56 ` Tony Luck
2012-09-06 6:48 ` Naveen N. Rao
2012-09-06 12:15 ` Borislav Petkov
2012-09-05 10:22 ` [PATCH 3/3] x86/mce: Honour bios-set CMCI threshold Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346865322.1906.7.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=bp@amd64.org \
--cc=gong.chen@linux.intel.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.