All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Cristiana Voicu <cristiana.voicu@intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] hob: print message when DISPLAY is not set
Date: Fri, 07 Sep 2012 14:47:13 +0100	[thread overview]
Message-ID: <1347025633.7493.67.camel@ted> (raw)
In-Reply-To: <1347019211-24363-1-git-send-email-cristiana.voicu@intel.com>

On Fri, 2012-09-07 at 15:00 +0300, Cristiana Voicu wrote:
> If DISPLAY wasn't set, launching hob has printed a traceback
> difficult to understand. Now, the exception is caught and it
> shows a human message.
> 
> [YOCTO #2596]
> 
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/builder.py |   13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

Merged to master, thanks.

> diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py
> index 7de4798..f9e54a8 100755
> --- a/bitbake/lib/bb/ui/crumbs/builder.py
> +++ b/bitbake/lib/bb/ui/crumbs/builder.py
> @@ -1334,4 +1341,4 @@ class Builder(gtk.Window):
>              format = bb.msg.BBLogFormatter("%(levelname)s: %(message)s")
>              self.consolelog.setFormatter(format)
>  
> -            self.logger.addHandler(self.consolelog)
> \ No newline at end of file
> +            self.logger.addHandler(self.consolelog)

I keep seeing this piece in your patches which doesn't seem to want to
apply and the line ending looks correct in the main repository. Can you
see if there is some problem locally?

Cheers,

Richard





      reply	other threads:[~2012-09-07 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 12:00 [PATCH] hob: print message when DISPLAY is not set Cristiana Voicu
2012-09-07 13:47 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347025633.7493.67.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=cristiana.voicu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.