From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, ak@linux.intel.com,
zheng.z.yan@intel.com, robert.richter@amd.com
Subject: Re: [PATCH 1/3] perf: use hrtimer for event multiplexing
Date: Fri, 07 Sep 2012 17:39:10 +0200 [thread overview]
Message-ID: <1347032350.18408.88.camel@twins> (raw)
In-Reply-To: <1347028169-1983-2-git-send-email-eranian@google.com>
On Fri, 2012-09-07 at 16:29 +0200, Stephane Eranian wrote:
> @@ -148,6 +148,15 @@ static LIST_HEAD(pmus);
> static DEFINE_MUTEX(pmus_lock);
> static struct srcu_struct pmus_srcu;
>
> +struct perf_cpu_hrtimer {
> + struct hrtimer hrtimer;
> + int active;
> +};
> +
> +static DEFINE_PER_CPU(struct list_head, rotation_list);
> +
> +static DEFINE_PER_CPU(struct perf_cpu_hrtimer, perf_cpu_hrtimer);
How about sticking the hrtimer in perf_cpu_context so you can have a
different rotation interval per PMU ?
Sorta like e9d2b064149ff7ef4acbc65a1b9374ac8b218d3e removed. Stopping
the timer when the PMU isn't over committed should solve the NOHZ
problem I think.
next prev parent reply other threads:[~2012-09-07 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 14:29 [PATCH 0/3] perf: use hrtimer for event multiplexing Stephane Eranian
2012-09-07 14:29 ` [PATCH 1/3] " Stephane Eranian
2012-09-07 15:39 ` Peter Zijlstra [this message]
2012-09-07 17:03 ` Stephane Eranian
2012-09-07 19:08 ` Peter Zijlstra
2012-09-07 19:10 ` Stephane Eranian
2012-09-07 19:14 ` Peter Zijlstra
2012-09-07 15:42 ` Peter Zijlstra
2012-09-07 14:29 ` [PATCH 2/3] perf: add sysctl control to adjust multiplexing interval Stephane Eranian
2012-09-07 14:29 ` [PATCH 3/3] perf: remove jiffies_interval Stephane Eranian
2012-09-07 15:40 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347032350.18408.88.camel@twins \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.