From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757616Ab2IJSNO (ORCPT ); Mon, 10 Sep 2012 14:13:14 -0400 Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:38264 "EHLO g5t0009.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757152Ab2IJSNL (ORCPT ); Mon, 10 Sep 2012 14:13:11 -0400 Subject: Re: [PATCH v2] Add missing attributes to EFI variable attribute print out from sysfs From: Khalid Aziz To: Greg KH Cc: Mike Waychison , "linux-kernel@vger.kernel.org" , Tony Luck , Matthew Garrett , Kees Cook , "gong.chen@linux.intel.com" , khalid@gonehiking.org In-Reply-To: <20120910180335.GA26021@kroah.com> References: <20120713174216.GA10445@hp.com> <20120910180335.GA26021@kroah.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 10 Sep 2012 12:13:09 -0600 Message-ID: <1347300789.4393.27.camel@lyra> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-09-10 at 11:03 -0700, Greg KH wrote: > On Mon, Sep 10, 2012 at 01:59:18PM -0400, Mike Waychison wrote: > > On Mon, Sep 10, 2012 at 1:55 PM, Mike Waychison wrote: > > > Greg, > > > > > > Can you please pick this patch up in one of your trees? > > > > Resend using a good email addy for gregkh :) > > Can someone resend it in a format that I can apply it in? I can't find > the original anymore, sorry. > > greg k-h Some of the EFI variable attributes are missing from print out from /sys/firmware/efi/vars/*/attributes. This patch adds those in. It also updates code to use pre-defined constants for masking current value of attributes. Signed-off-by: Khalid Aziz diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 47408e8..d10c987 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -435,12 +435,23 @@ efivar_attr_read(struct efivar_entry *entry, char *buf) if (status != EFI_SUCCESS) return -EIO; - if (var->Attributes & 0x1) + if (var->Attributes & EFI_VARIABLE_NON_VOLATILE) str += sprintf(str, "EFI_VARIABLE_NON_VOLATILE\n"); - if (var->Attributes & 0x2) + if (var->Attributes & EFI_VARIABLE_BOOTSERVICE_ACCESS) str += sprintf(str, "EFI_VARIABLE_BOOTSERVICE_ACCESS\n"); - if (var->Attributes & 0x4) + if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS) str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n"); + if (var->Attributes & EFI_VARIABLE_HARDWARE_ERROR_RECORD) + str += sprintf(str, "EFI_VARIABLE_HARDWARE_ERROR_RECORD\n"); + if (var->Attributes & EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS) + str += sprintf(str, + "EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS\n"); + if (var->Attributes & + EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS) + str += sprintf(str, + "EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS\n"); + if (var->Attributes & EFI_VARIABLE_APPEND_WRITE) + str += sprintf(str, "EFI_VARIABLE_APPEND_WRITE\n"); return str - buf; } -- 1.7.9.5 -- Khalid Aziz