From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758150Ab2IJS6p (ORCPT <rfc822;w@1wt.eu>);
	Mon, 10 Sep 2012 14:58:45 -0400
Received: from g4t0014.houston.hp.com ([15.201.24.17]:29416 "EHLO
	g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754203Ab2IJS6o (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 10 Sep 2012 14:58:44 -0400
Subject: Re: [PATCH v2] Add missing attributes to EFI variable attribute
 print out from sysfs
From: Khalid Aziz <khalid.aziz@hp.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Mike Waychison <mikew@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Tony Luck <tony.luck@intel.com>, Matthew Garrett <mjg@redhat.com>,
        Kees Cook <keescook@chromium.org>,
        "gong.chen@linux.intel.com" <gong.chen@linux.intel.com>,
        khalid@gonehiking.org
In-Reply-To: <20120910183506.GA25975@kroah.com>
References: <20120713174216.GA10445@hp.com>
	 <CAGTjWtDyGrVuBXZzdDfbS961cRSQY7eZaEbb9E8HACk5-imiuQ@mail.gmail.com>
	 <CAGTjWtAPKXfA7pOqWEfK2i_HbrtA6_w7+ezZyCo4NG1gBSEhwg@mail.gmail.com>
	 <20120910180335.GA26021@kroah.com> <1347300789.4393.27.camel@lyra>
	 <20120910181855.GA26404@kroah.com> <20120910182914.GA12076@ldl.usa.hp.com>
	 <20120910183506.GA25975@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 10 Sep 2012 12:58:43 -0600
Message-ID: <1347303523.4393.31.camel@lyra>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2012-09-10 at 11:35 -0700, Greg KH wrote:
> On Mon, Sep 10, 2012 at 12:29:14PM -0600, Khalid Aziz wrote:
> > Some of the EFI variable attributes are missing from print out from
> > /sys/firmware/efi/vars/*/attributes. This patch adds those in. It also
> > updates code to use pre-defined constants for masking current value
> > of attributes.
> > 
> > Signed-off-by: Khalid Aziz <khalid.aziz@hp.com>
> > Reviewed-by: Kees Cook <keescook@chromium.org>
> > Acked-by: Matthew Garrett <mjg@redhat.com>
> > Cc: stable@vger.kernel.org
> > ---
> >  drivers/firmware/efivars.c |   17 ++++++++++++++---
> >  1 file changed, 14 insertions(+), 3 deletions(-)
> > diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> > index 47408e8..d10c987 100644
> 
> Ah, so close...
> 
> What's with the "Re:" in the Subject"?
> 
> And what happened to the extra line that should be after the diffstat
> and before the "diff --" line?
> 
> Third time's a charm?

Sorry, Greg. I screwed up. I need to pay closer attention. Hopefully the
one I just sent out does the job.

-- 
Khalid Aziz <khalid.aziz@hp.com>