From: Cong Wang <amwang@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Roland McGrath <roland@hack.frob.com>
Subject: Re: [PATCH] fs: prevent double-free on an error path in core dumper
Date: Wed, 12 Sep 2012 13:06:07 +0800 [thread overview]
Message-ID: <1347426367.29533.13.camel@cr0> (raw)
In-Reply-To: <20120911155950.GA7431@redhat.com>
On Tue, 2012-09-11 at 17:59 +0200, Oleg Nesterov wrote:
> But, again, the caller does free_note_info(), so why
> elf_note_info_init()
> tries to handle the kmalloc failures? Afaics, we can simplify the code
> and fix the bug.
>
> What do you think about the patch below?
Looks reasonable and neat. :)
next prev parent reply other threads:[~2012-09-12 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347380162-2359-1-git-send-email-vda.linux@googlemail.com>
2012-09-11 15:59 ` [PATCH] fs: prevent double-free on an error path in core dumper Oleg Nesterov
2012-09-12 5:06 ` Cong Wang [this message]
2012-09-12 11:33 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347426367.29533.13.camel@cr0 \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@hack.frob.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.