diff for duplicates of <1347454564-5178-4-git-send-email-peter.senna@gmail.com> diff --git a/a/1.txt b/N1/1.txt index d4678fc..2d01968 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -11,7 +11,7 @@ position p1,p2; expression x; @@ -if (x@p1 = NULL) { ... kfree@p2(x); ... return ...; } +if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged exists@ position r.p1,r.p2; @@ -20,7 +20,7 @@ iterator I; statement S; @@ -if (x@p1 = NULL) { ... when != I(x,...) S +if (x@p1 == NULL) { ... when != I(x,...) S when != e = e1 when != e += e1 when != e -= e1 @@ -37,7 +37,7 @@ position r.p2; expression x; @@ -... when != true x@p1 = NULL +... when != true x@p1 == NULL kfree@p2(x); @depends on !ok && unchanged@ @@ -62,7 +62,7 @@ index 2e93e65..45f9523 100644 struct stb6100_state *state = NULL; state = kzalloc(sizeof (struct stb6100_state), GFP_KERNEL); -- if (state = NULL) +- if (state == NULL) - goto error; + if (!state) + return NULL; diff --git a/a/content_digest b/N1/content_digest index 4fc36f4..981b2f1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Peter Senna Tschudin <peter.senna@gmail.com>\0" "Subject\0[PATCH v2 5/8] drivers/media/dvb-frontends/stb6100.c: Removes useless kfree()\0" - "Date\0Wed, 12 Sep 2012 12:56:00 +0000\0" + "Date\0Wed, 12 Sep 2012 14:56:00 +0200\0" "To\0Mauro Carvalho Chehab <mchehab@infradead.org>\0" "Cc\0kernel-janitors@vger.kernel.org" linux-media@vger.kernel.org @@ -20,7 +20,7 @@ "expression x;\n" "@@\n" "\n" - "if (x@p1 = NULL) { ... kfree@p2(x); ... return ...; }\n" + "if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }\n" "\n" "@unchanged exists@\n" "position r.p1,r.p2;\n" @@ -29,7 +29,7 @@ "statement S;\n" "@@\n" "\n" - "if (x@p1 = NULL) { ... when != I(x,...) S\n" + "if (x@p1 == NULL) { ... when != I(x,...) S\n" " when != e = e1\n" " when != e += e1\n" " when != e -= e1\n" @@ -46,7 +46,7 @@ "expression x;\n" "@@\n" "\n" - "... when != true x@p1 = NULL\n" + "... when != true x@p1 == NULL\n" "kfree@p2(x);\n" "\n" "@depends on !ok && unchanged@\n" @@ -71,7 +71,7 @@ " \tstruct stb6100_state *state = NULL;\n" " \n" " \tstate = kzalloc(sizeof (struct stb6100_state), GFP_KERNEL);\n" - "-\tif (state = NULL)\n" + "-\tif (state == NULL)\n" "-\t\tgoto error;\n" "+\tif (!state)\n" "+\t\treturn NULL;\n" @@ -90,4 +90,4 @@ " \n" static int stb6100_release(struct dvb_frontend *fe) -6d2edfb8e97ddc146af292ca48a8d318ad7938a4987c2ce02af19b6a8d2294c7 +7a93ebbf5efe989e4ae25f1b10b6de1608ec5e03bd3ebb03eac1ca6e28d97bfa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.