From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Oleg Nesterov <oleg@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH] perf, intel: Don't touch MSR_IA32_DEBUGCTLMSR from NMI context
Date: Thu, 13 Sep 2012 14:11:05 +0200 [thread overview]
Message-ID: <1347538265.15764.129.camel@twins> (raw)
In-Reply-To: <CABPqkBQk2TsnyZF52rvcH9wKO=P7=RAgTTjYPQjeAjOFUob4_g@mail.gmail.com>
On Thu, 2012-09-13 at 13:49 +0200, Stephane Eranian wrote:
> Should be, though it is pretty ugly to stash all of this in the
> put/get constraints.
Agreed, I almost added two extra functions for it but when I went to
look at where to call them I ended up next to get/put constraints.
> I will run some tests.
>
> I wonder what this does when you come in to get/put with a fake cpuc. You don't
> want to perturb the local lbr which may be in use.
Fake cpu will never set ->alloc and thus intel_pmu_has_lbr() should fail
and we don't do anything.
prev parent reply other threads:[~2012-09-13 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 16:22 [RFC][PATCH] perf, intel: Don't touch MSR_IA32_DEBUGCTLMSR from NMI context Peter Zijlstra
2012-09-12 16:42 ` Stephane Eranian
2012-09-12 17:37 ` Peter Zijlstra
2012-09-12 17:45 ` Peter Zijlstra
2012-09-12 18:00 ` Stephane Eranian
2012-09-12 18:17 ` Peter Zijlstra
2012-09-12 18:50 ` Stephane Eranian
2012-09-12 18:52 ` Peter Zijlstra
2012-09-12 19:00 ` Stephane Eranian
2012-09-12 17:36 ` Oleg Nesterov
2012-09-12 17:41 ` Peter Zijlstra
2012-09-13 10:23 ` Peter Zijlstra
2012-09-13 11:49 ` Stephane Eranian
2012-09-13 12:11 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347538265.15764.129.camel@twins \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.