From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org,
Robert Richter <robert.richter@amd.com>
Subject: Re: [PATCH 3/3 v2] perf tool: give user better message if precise is not supported
Date: Fri, 14 Sep 2012 23:26:02 +0200 [thread overview]
Message-ID: <1347657962.7172.82.camel@twins> (raw)
In-Reply-To: <20120914201138.GA17024@gmail.com>
On Fri, 2012-09-14 at 22:11 +0200, Ingo Molnar wrote:
> return -EPERF_CPU_PRECISE_EV_NOTSUPP;
I just don't like having to enumerate all possible fails, I'm too lazy.
Can't we be smarter about that? Could we do a {reason}x{bit-offset} like
thing?
Where we limit reason to a few simple things like:
invalid
out-of-range
not-supported
and have the bit-offset indicate the field we're having the particular
problem with?
Then all we need is a smart way to generate and map the bit-offsets
without too much manual labour.
next prev parent reply other threads:[~2012-09-14 21:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 20:59 [PATCH 0/3 v3] perf: precise mode and exclude_guest David Ahern
2012-09-13 20:59 ` [PATCH 1/3] perf tool: precise mode requires exclude_guest David Ahern
2012-10-20 0:55 ` [tip:perf/urgent] perf tool: Precise " tip-bot for David Ahern
2012-09-13 20:59 ` [PATCH 2/3] perf: require exclude_guest to use PEBS - kernel side enforcement David Ahern
2012-10-20 0:56 ` [tip:perf/urgent] perf: Require " tip-bot for Peter Zijlstra
2012-09-13 20:59 ` [PATCH 3/3 v2] perf tool: give user better message if precise is not supported David Ahern
2012-09-14 5:43 ` Ingo Molnar
2012-09-14 11:13 ` David Ahern
2012-09-14 11:36 ` Ingo Molnar
2012-09-14 11:43 ` David Ahern
2012-09-14 18:00 ` Arnaldo Carvalho de Melo
2012-09-14 18:07 ` Peter Zijlstra
2012-09-14 20:05 ` Ingo Molnar
2012-09-14 20:11 ` Ingo Molnar
2012-09-14 21:26 ` Peter Zijlstra [this message]
2012-09-17 7:11 ` Ingo Molnar
2012-10-25 8:01 ` [tip:perf/core] perf tools: Give " tip-bot for David Ahern
2012-09-26 1:24 ` [PATCH 0/3 v3] perf: precise mode and exclude_guest David Ahern
2012-10-09 15:08 ` David Ahern
-- strict thread matches above, loose matches on Subject: below --
2012-09-12 15:16 [PATCH 0/3 v2] " David Ahern
2012-09-12 15:16 ` [PATCH 3/3 v2] perf tool: give user better message if precise is not supported David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347657962.7172.82.camel@twins \
--to=peterz@infradead.org \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.