From: Johannes Berg <johannes@sipsolutions.net>
To: artem.bityutskiy@linux.intel.com
Cc: Eric Dumazet <edumazet@google.com>, linux-wireless@vger.kernel.org
Subject: Re: regression: tethering fails in 3.5 with iwlwifi
Date: Tue, 18 Sep 2012 09:09:59 +0200 [thread overview]
Message-ID: <1347952199.6503.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1347892887.7112.9.camel@sauron.fi.intel.com> (sfid-20120917_163617_677167_0B529F43)
On Mon, 2012-09-17 at 17:41 +0300, Artem Bityutskiy wrote:
> OK, finally I got it. After 3 days of hardcore intelligent bisecting
> I've found out that tethering in 3.5 works for me if I revert
> these 2
> patches:
>
> 56138f5 iwlwifi: dont pull too much payload in skb head
> 3edaf3e mac80211: manage AP netdev carrier state
Hm. This is curious. *How* does AP mode fail? You said earlier stations
failed to connect, but can they actually get associated? I'm curious
because while I could see the carrier state thing causing issues (on old
hostapd versions that we didn't test), I'm not sure I see how the skb
payload makes a difference since mac80211 will linearize management
frames (so association should work) and data frames don't matter (so
authorization should work) ... unless there's a bug somewhere in
mac80211 where it forgets to pskb_may_pull(), but I don't see any such
place right now.
johannes
next prev parent reply other threads:[~2012-09-18 7:09 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347361823.26457.3.camel@sauron.fi.intel.com>
[not found] ` <1DC40B07CD6EC041A66726C271A73AE6195AE9C8@IRSMSX102.ger.corp.intel.com>
2012-09-14 14:02 ` regression: tethering fails in 3.5 with iwlwifi Artem Bityutskiy
2012-09-14 16:39 ` Artem Bityutskiy
2012-09-17 14:41 ` Artem Bityutskiy
2012-09-17 15:15 ` Eric Dumazet
2012-09-17 15:17 ` Johannes Berg
2012-09-18 7:09 ` Johannes Berg [this message]
2012-09-18 8:40 ` Artem Bityutskiy
2012-09-18 8:44 ` Johannes Berg
2012-09-18 11:45 ` Johannes Berg
2012-09-18 13:20 ` Artem Bityutskiy
2012-09-20 12:06 ` Artem Bityutskiy
2012-09-20 12:35 ` Johannes Berg
2012-09-20 12:40 ` Eric Dumazet
2012-09-20 12:40 ` Eric Dumazet
2012-09-20 12:45 ` Eric Dumazet
2012-09-20 12:46 ` Eric Dumazet
2012-09-20 12:50 ` Johannes Berg
2012-09-20 12:50 ` Johannes Berg
2012-09-20 12:47 ` Johannes Berg
2012-09-20 12:48 ` Eric Dumazet
2012-09-20 12:48 ` Eric Dumazet
2012-09-20 12:50 ` Johannes Berg
2012-09-20 12:51 ` Eric Dumazet
2012-09-20 12:51 ` Eric Dumazet
2012-09-20 12:54 ` Johannes Berg
2012-09-20 12:54 ` Johannes Berg
2012-09-20 12:51 ` Johannes Berg
2012-09-20 12:58 ` Artem Bityutskiy
2012-09-20 12:58 ` Artem Bityutskiy
2012-09-20 13:04 ` Eric Dumazet
2012-09-20 13:04 ` Eric Dumazet
2012-09-20 13:15 ` Eric Dumazet
2012-09-20 13:15 ` Eric Dumazet
2012-09-20 13:22 ` Artem Bityutskiy
2012-09-20 13:22 ` Eric Dumazet
2012-09-20 13:39 ` Artem Bityutskiy
2012-09-20 13:41 ` Eric Dumazet
2012-09-20 14:25 ` Eric Dumazet
2012-09-20 14:37 ` Artem Bityutskiy
2012-09-20 14:56 ` Eric Dumazet
2012-09-20 15:05 ` Johannes Berg
2012-09-20 15:18 ` Eric Dumazet
2012-09-20 15:22 ` Johannes Berg
2012-09-20 15:27 ` Eric Dumazet
2012-09-20 15:31 ` Eric Dumazet
2012-09-20 15:32 ` Eric Dumazet
2012-09-20 15:19 ` Eric Dumazet
2012-09-20 15:26 ` Johannes Berg
2012-09-20 15:09 ` Artem Bityutskiy
2012-09-21 17:24 ` David Miller
2012-09-21 17:24 ` David Miller
2012-09-20 12:47 ` Johannes Berg
2012-09-20 12:47 ` Johannes Berg
2013-03-21 19:34 ` Johannes Berg
2013-03-21 21:24 ` David Miller
2013-03-22 7:01 ` Artem Bityutskiy
2013-03-22 7:01 ` Artem Bityutskiy
2013-03-23 15:45 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347952199.6503.3.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=artem.bityutskiy@linux.intel.com \
--cc=edumazet@google.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.