From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: jbaron@redhat.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 5/6] dyndbg: in dynamic_emit_prefix, change inter-field separator
Date: Tue, 18 Sep 2012 19:56:42 -0700 [thread overview]
Message-ID: <1348023402.11276.5.camel@joe2Laptop> (raw)
In-Reply-To: <1348011407-24108-6-git-send-email-jim.cromie@gmail.com>
On Tue, 2012-09-18 at 17:36 -0600, Jim Cromie wrote:
> dynamic_emit_prefix() currently separates modname, funcname, lineno
> with ':'. This is confounds use of cut -d: <logfile>, since the field
> positions can change per callsite with dynamic-debug. So change
> inter-field separator to '.' and keep the ':' prefix terminator.
>
> This improves the situation, but doesnt solve it entirely; if
> dyndbg==p is used instead of dyndbg==p[fmlt]+, the callsite is enabled
> but no prefix is added, so theres one less ':' in the message.
> Changing the terminator to ',' would fix this, and might be warranted,
> especially since pr_fmt() typically adds a ':' as well.
>
> Joe Perches wasnt a fan of this, but his complaint was essentially
> that cut -d: was a poor way to do this kind of thing. I concede that
> point, but note that the kernel is not in the habit of needlessly
> confounding users work, at least when accommodating them is so trivial.
And I still think this is ugly as it requires different parsing
by scripts when using combinations of +pfmlt
next prev parent reply other threads:[~2012-09-19 2:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348011407-24108-1-git-send-email-jim.cromie@gmail.com>
2012-09-18 23:36 ` [PATCH 1/6] dyndbg: fix usability bug by adding pr_errs for -EINVALs Jim Cromie
2012-09-18 23:36 ` [PATCH 2/6] dyndbg: spelling fix s/conrol/control/ Jim Cromie
2012-09-18 23:36 ` [PATCH 3/6] dyndbg: add more info to -E2BIG log warning Jim Cromie
2012-09-24 19:00 ` Jason Baron
2012-09-24 19:04 ` Geert Uytterhoeven
2012-09-24 21:15 ` Jim Cromie
2012-09-18 23:36 ` [PATCH 4/6] dyndbg: increase verbosity for proc-show, proc-next Jim Cromie
2012-09-18 23:36 ` [PATCH 5/6] dyndbg: in dynamic_emit_prefix, change inter-field separator Jim Cromie
2012-09-19 2:56 ` Joe Perches [this message]
2012-09-24 19:04 ` Jason Baron
2012-09-18 23:36 ` [PATCH 6/6] dyndbg: change varname verbose_bytes to bytes_used Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348023402.11276.5.camel@joe2Laptop \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.