All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Neumann <s.neumann@raumfeld.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wpa-supplicant: add options to enable the new DBus interface
Date: Wed, 19 Sep 2012 11:02:57 +0200	[thread overview]
Message-ID: <1348045377.23228.3.camel@sven> (raw)
In-Reply-To: <505810D1.8070806@essensium.com>

Hi,

thanks a lot for your review. I'll make the changes you suggested, but I
am not sure about the following:

On Tue, 2012-09-18 at 08:12 +0200, Arnout Vandecappelle wrote:

> > +config BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD
> > +	bool "Enable support for old DBus control interface"
> > +        depends on BR2_PACKAGE_DBUS
> 
>    Use 1 tab instead of 8 spaces (below as well).
> 
>   Also, I think it's better to make this
>      select BR2_PACKAGE_DBUS
>      depends on BR2_TOOLCHAIN_HAS_THREADS
> 
>   Also, since this only installs a .service file, and it used to be
> always enabled before, I would make at least one of the two
> DBus interfaces enabled by default.

If I follow this suggestion and enable one of the DBus interfaces by
default, then selecting wpa-supplicant would select DBus, which it did
not do before. Is that really desired?


Regards,
Sven

  parent reply	other threads:[~2012-09-19  9:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  8:34 [Buildroot] wpa-supplicant: add options to enable the new DBus interface Sven Neumann
2012-09-13  8:34 ` [Buildroot] [PATCH] " Sven Neumann
2012-09-18 22:04   ` Arnout Vandecappelle
2012-09-19 10:11     ` [Buildroot] wpa_supplicant changes Sven Neumann
2012-09-19 10:11       ` [Buildroot] [PATCH 1/3] wpa-supplicant: add options to enable the new DBus interface Sven Neumann
2012-09-19 19:56         ` Arnout Vandecappelle
2012-09-19 19:59           ` Arnout Vandecappelle
2012-09-19 10:11       ` [Buildroot] [PATCH 2/3] wpa_supplicant: remove redundant escaping from sed commands Sven Neumann
2012-09-19 20:06         ` Arnout Vandecappelle
2012-09-19 10:11       ` [Buildroot] [PATCH 3/3] wpa_supplicant: introduce macros for editing the .config file Sven Neumann
2012-09-19 20:33         ` Arnout Vandecappelle
     [not found]   ` <505810D1.8070806@essensium.com>
2012-09-19  9:02     ` Sven Neumann [this message]
2012-09-19 20:03       ` [Buildroot] [PATCH] wpa-supplicant: add options to enable the new DBus interface Arnout Vandecappelle
  -- strict thread matches above, loose matches on Subject: below --
2012-07-18 20:52 Sven Neumann
2012-09-04 13:38 ` Sven Neumann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348045377.23228.3.camel@sven \
    --to=s.neumann@raumfeld.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.