From mboxrd@z Thu Jan 1 00:00:00 1970 From: pawel.moll@arm.com (Pawel Moll) Date: Wed, 19 Sep 2012 12:45:49 +0100 Subject: [PATCH v2 08/13] mfd: Versatile Express system registers driver In-Reply-To: <201209191117.45316.arnd@arndb.de> References: <1347977875-16855-1-git-send-email-pawel.moll@arm.com> <201209181524.22620.arnd@arndb.de> <1348052009.11116.55.camel@hornet> <201209191117.45316.arnd@arndb.de> Message-ID: <1348055149.11116.63.camel@hornet> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2012-09-19 at 12:17 +0100, Arnd Bergmann wrote: > On Wednesday 19 September 2012, Pawel Moll wrote: > > On Tue, 2012-09-18 at 16:24 +0100, Arnd Bergmann wrote: > > > On Tuesday 18 September 2012, Pawel Moll wrote: > > > > Yes, but I2C devices are created by of_i2c_register_devices() which > > knows how to interpret the reg property. And here, as these are normal > > platform devices now (as you suggested), the of_platform_bus_create() > > will treat it as a normal address, translate it via ranges and create > > IORESOURCE_MEM out of it... And that's what I wanted to avoid. Maybe > > unnecessarily? > > You are right, this is a bit nasty, it should not attempt to do this. > Basically the reg parsing logic has a hack to work around apply PowerMac > firmware that misses some "ranges" properties. > > I think we should change the DT parsing code to not create those > resources if there is a bus that can't be translated. Well, I actually think the current solution is fine - the default bus is the platform one, I'm creating a platform device, so the code can assume that reg is a normal address and create an IORESOURCE_MEM from it. It's just that my platform device is not memory mapped, so I don't really want this to happen. One way of working this around would be not using "simple-bus" as the parent of my config devices, so that normal of_platform_populate() will not create them, and then have a simple dcc driver that will do nothing except for creating platform devices in a custom way. Pawe? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pawel Moll Subject: Re: [PATCH v2 08/13] mfd: Versatile Express system registers driver Date: Wed, 19 Sep 2012 12:45:49 +0100 Message-ID: <1348055149.11116.63.camel@hornet> References: <1347977875-16855-1-git-send-email-pawel.moll@arm.com> <201209181524.22620.arnd@arndb.de> <1348052009.11116.55.camel@hornet> <201209191117.45316.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201209191117.45316.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: device-tree , "arm@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org T24gV2VkLCAyMDEyLTA5LTE5IGF0IDEyOjE3ICswMTAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ IE9uIFdlZG5lc2RheSAxOSBTZXB0ZW1iZXIgMjAxMiwgUGF3ZWwgTW9sbCB3cm90ZToKPiA+IE9u IFR1ZSwgMjAxMi0wOS0xOCBhdCAxNjoyNCArMDEwMCwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiA+ ID4gT24gVHVlc2RheSAxOCBTZXB0ZW1iZXIgMjAxMiwgUGF3ZWwgTW9sbCB3cm90ZToKPiA+IAo+ ID4gWWVzLCBidXQgSTJDIGRldmljZXMgYXJlIGNyZWF0ZWQgYnkgb2ZfaTJjX3JlZ2lzdGVyX2Rl dmljZXMoKSB3aGljaAo+ID4ga25vd3MgaG93IHRvIGludGVycHJldCB0aGUgcmVnIHByb3BlcnR5 LiBBbmQgaGVyZSwgYXMgdGhlc2UgYXJlIG5vcm1hbAo+ID4gcGxhdGZvcm0gZGV2aWNlcyBub3cg KGFzIHlvdSBzdWdnZXN0ZWQpLCB0aGUgb2ZfcGxhdGZvcm1fYnVzX2NyZWF0ZSgpCj4gPiB3aWxs IHRyZWF0IGl0IGFzIGEgbm9ybWFsIGFkZHJlc3MsIHRyYW5zbGF0ZSBpdCB2aWEgcmFuZ2VzIGFu ZCBjcmVhdGUKPiA+IElPUkVTT1VSQ0VfTUVNIG91dCBvZiBpdC4uLiBBbmQgdGhhdCdzIHdoYXQg SSB3YW50ZWQgdG8gYXZvaWQuIE1heWJlCj4gPiB1bm5lY2Vzc2FyaWx5Pwo+IAo+IFlvdSBhcmUg cmlnaHQsIHRoaXMgaXMgYSBiaXQgbmFzdHksIGl0IHNob3VsZCBub3QgYXR0ZW1wdCB0byBkbyB0 aGlzLgo+IEJhc2ljYWxseSB0aGUgcmVnIHBhcnNpbmcgbG9naWMgaGFzIGEgaGFjayB0byB3b3Jr IGFyb3VuZCBhcHBseSBQb3dlck1hYwo+IGZpcm13YXJlIHRoYXQgbWlzc2VzIHNvbWUgInJhbmdl cyIgcHJvcGVydGllcy4KPiAKPiBJIHRoaW5rIHdlIHNob3VsZCBjaGFuZ2UgdGhlIERUIHBhcnNp bmcgY29kZSB0byBub3QgY3JlYXRlIHRob3NlCj4gcmVzb3VyY2VzIGlmIHRoZXJlIGlzIGEgYnVz IHRoYXQgY2FuJ3QgYmUgdHJhbnNsYXRlZC4KCldlbGwsIEkgYWN0dWFsbHkgdGhpbmsgdGhlIGN1 cnJlbnQgc29sdXRpb24gaXMgZmluZSAtIHRoZSBkZWZhdWx0IGJ1cyBpcwp0aGUgcGxhdGZvcm0g b25lLCBJJ20gY3JlYXRpbmcgYSBwbGF0Zm9ybSBkZXZpY2UsIHNvIHRoZSBjb2RlIGNhbiBhc3N1 bWUKdGhhdCByZWcgaXMgYSBub3JtYWwgYWRkcmVzcyBhbmQgY3JlYXRlIGFuIElPUkVTT1VSQ0Vf TUVNIGZyb20gaXQuIEl0J3MKanVzdCB0aGF0IG15IHBsYXRmb3JtIGRldmljZSBpcyBub3QgbWVt b3J5IG1hcHBlZCwgc28gSSBkb24ndCByZWFsbHkKd2FudCB0aGlzIHRvIGhhcHBlbi4KCk9uZSB3 YXkgb2Ygd29ya2luZyB0aGlzIGFyb3VuZCB3b3VsZCBiZSBub3QgdXNpbmcgInNpbXBsZS1idXMi IGFzIHRoZQpwYXJlbnQgb2YgbXkgY29uZmlnIGRldmljZXMsIHNvIHRoYXQgbm9ybWFsIG9mX3Bs YXRmb3JtX3BvcHVsYXRlKCkgd2lsbApub3QgY3JlYXRlIHRoZW0sIGFuZCB0aGVuIGhhdmUgYSBz aW1wbGUgZGNjIGRyaXZlciB0aGF0IHdpbGwgZG8gbm90aGluZwpleGNlcHQgZm9yIGNyZWF0aW5n IHBsYXRmb3JtIGRldmljZXMgaW4gYSBjdXN0b20gd2F5LgoKUGF3ZcWCCgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK