From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: viresh kumar <viresh.kumar@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
spear-devel@list.st.com, linux-kernel@vger.kernel.org,
Hein Tibosch <hein_tibosch@yahoo.es>
Subject: Re: [PATCH 2/7] dw_dmac: fill optional encoded parameters in register structure
Date: Thu, 20 Sep 2012 12:30:05 +0300 [thread overview]
Message-ID: <1348133405.13371.30.camel@smile> (raw)
In-Reply-To: <CAOh2x=k3hjXtuAd23LYLWvG59HPgFS8W2J+5-2Bre+wFufgcng@mail.gmail.com>
On Tue, 2012-09-18 at 13:29 +0530, viresh kumar wrote:
> On Tue, Sep 18, 2012 at 12:25 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >> > +#define dma_raw_readl(addr, name) \
> >> > + readl((addr) + offsetof(struct dw_dma_regs, name))
> >> > +
> >> > +#define dma_raw_writel(addr, name, val) \
> >> > + writel((val), (addr) + offsetof(struct dw_dma_regs, name))
> >> > +
> >>
> >> But why don't you use earlier defined readl/writel macros:
> >> dma_readl and dma_writel?
>
> > If you look at further patches, namely 3rd, the access to the register
> > is needed before we allocate memory for the dw_dma structure.
>
> Ok. If i am not wrong, such calls are only required once for below line:
Actually twice...
> dw_params = dma_raw_readl(regs, DW_PARAMS
...here and for channel parameters.
> dma_raw_writel() is not used and shouldn't be required in future too.
> So remove it.
Ok
> dma_raw_readl() is required but the name is a bit confusing... this
> raw type is different
> from raw_readl...
>
> Can we name it dma_read_byaddr()?
> to make it more explicit.
Ok.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2012-09-20 9:30 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 7:39 [PATCH 0/7] dw_dmac: introduce autoconfiguration Andy Shevchenko
2012-09-17 7:39 ` [PATCH 1/7] dw_dmac: mark dwc_dump_chan_regs as inline Andy Shevchenko
2012-09-18 6:35 ` viresh kumar
2012-09-17 7:39 ` [PATCH 2/7] dw_dmac: fill optional encoded parameters in register structure Andy Shevchenko
2012-09-18 6:39 ` viresh kumar
2012-09-18 6:55 ` Andy Shevchenko
2012-09-18 7:59 ` viresh kumar
2012-09-20 9:30 ` Andy Shevchenko [this message]
2012-09-20 9:32 ` viresh kumar
2012-09-20 9:51 ` Andy Shevchenko
2012-09-17 7:39 ` [PATCH 3/7] dw_dmac: get number of channels from hardware if possible Andy Shevchenko
2012-09-18 6:50 ` viresh kumar
2012-09-20 9:35 ` Andy Shevchenko
2012-09-20 9:40 ` viresh kumar
2012-09-21 6:04 ` viresh kumar
2012-09-17 7:39 ` [PATCH 4/7] dw_dmac: autoconfigure block_size or use platform data Andy Shevchenko
2012-09-18 6:57 ` viresh kumar
2012-09-20 9:38 ` Andy Shevchenko
2012-09-17 7:39 ` [PATCH 5/7] dw_dmac: autoconfigure data_width or get it via " Andy Shevchenko
2012-09-18 7:11 ` viresh kumar
2012-09-20 9:42 ` Andy Shevchenko
2012-09-20 9:46 ` viresh kumar
2012-09-20 9:53 ` Andy Shevchenko
2012-09-17 7:39 ` [PATCH 6/7] dw_dmac: check if controller supports LLP Andy Shevchenko
2012-09-18 7:13 ` viresh kumar
2012-09-20 9:43 ` Andy Shevchenko
2012-09-17 7:39 ` [PATCH 7/7] dw_dmac: introduce software emulation of LLP transfers Andy Shevchenko
2012-09-18 7:17 ` viresh kumar
2012-09-20 9:46 ` Andy Shevchenko
2012-09-17 16:50 ` [PATCH 0/7] dw_dmac: introduce autoconfiguration Hein Tibosch
2012-09-18 6:11 ` Hein Tibosch
2012-09-18 7:18 ` viresh kumar
2012-09-20 9:48 ` Andy Shevchenko
2012-09-21 12:05 ` [PATCHv2 0/6] " Andy Shevchenko
2012-09-21 12:05 ` [PATCHv2 1/6] dw_dmac: mark dwc_dump_chan_regs as inline Andy Shevchenko
2012-09-21 12:05 ` [PATCHv2 2/6] dw_dmac: fill optional encoded parameters in register structure Andy Shevchenko
2012-09-21 13:55 ` viresh kumar
2012-09-21 12:05 ` [PATCHv2 3/6] dw_dmac: get number of channels from hardware if possible Andy Shevchenko
2012-09-21 13:56 ` viresh kumar
2012-09-21 12:05 ` [PATCHv2 4/6] dw_dmac: autoconfigure block_size or use platform data Andy Shevchenko
2012-09-21 14:00 ` viresh kumar
2012-09-21 15:09 ` Andy Shevchenko
2012-09-21 15:30 ` Viresh Kumar
2012-09-21 12:05 ` [PATCHv2 5/6] dw_dmac: autoconfigure data_width or get it via " Andy Shevchenko
2012-09-21 14:02 ` viresh kumar
2012-09-25 11:39 ` [PATCHv3] " Andy Shevchenko
2012-09-26 3:29 ` viresh kumar
2012-09-27 10:06 ` Vinod Koul
2012-09-27 10:33 ` Vinod Koul
2012-09-27 13:10 ` Andy Shevchenko
2012-10-01 9:04 ` Andy Shevchenko
2012-10-01 9:45 ` Vinod Koul
2012-10-01 10:07 ` Andy Shevchenko
2012-09-27 14:00 ` Andy Shevchenko
2012-09-27 14:27 ` Vinod Koul
2012-09-21 12:05 ` [PATCHv2 6/6] dw_dmac: introduce software emulation of LLP transfers Andy Shevchenko
2012-09-21 14:03 ` viresh kumar
2012-09-27 10:05 ` [PATCHv2 0/6] dw_dmac: introduce autoconfiguration Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348133405.13371.30.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=hein_tibosch@yahoo.es \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.