From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: g.liakhovetski@gmx.de
Cc: maramaopercheseimorto@gmail.com, linux-media@vger.kernel.org,
"Frank Schäfer" <fschaefer.oss@googlemail.com>
Subject: [PATCH v2 3/3] ov2640: simplify single register writes
Date: Sun, 23 Sep 2012 21:28:46 +0300 [thread overview]
Message-ID: <1348424926-12864-3-git-send-email-fschaefer.oss@googlemail.com> (raw)
In-Reply-To: <1348424926-12864-1-git-send-email-fschaefer.oss@googlemail.com>
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
---
drivers/media/i2c/soc_camera/ov2640.c | 17 ++++++++---------
1 Datei geändert, 8 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-)
diff --git a/drivers/media/i2c/soc_camera/ov2640.c b/drivers/media/i2c/soc_camera/ov2640.c
index 182d5a1..e71bf4c 100644
--- a/drivers/media/i2c/soc_camera/ov2640.c
+++ b/drivers/media/i2c/soc_camera/ov2640.c
@@ -639,17 +639,19 @@ static struct ov2640_priv *to_ov2640(const struct i2c_client *client)
subdev);
}
+static int ov2640_write_single(struct i2c_client *client, u8 reg, u8 val)
+{
+ dev_vdbg(&client->dev, "write: 0x%02x, 0x%02x", reg, val);
+ return i2c_smbus_write_byte_data(client, reg, val);
+}
+
static int ov2640_write_array(struct i2c_client *client,
const struct regval_list *vals)
{
int ret;
while ((vals->reg_num != 0xff) || (vals->value != 0xff)) {
- ret = i2c_smbus_write_byte_data(client,
- vals->reg_num, vals->value);
- dev_vdbg(&client->dev, "array: 0x%02x, 0x%02x",
- vals->reg_num, vals->value);
-
+ ret = ov2640_write_single(client, vals->reg_num, vals->value);
if (ret < 0)
return ret;
vals++;
@@ -704,13 +706,10 @@ static int ov2640_s_ctrl(struct v4l2_ctrl *ctrl)
struct v4l2_subdev *sd =
&container_of(ctrl->handler, struct ov2640_priv, hdl)->subdev;
struct i2c_client *client = v4l2_get_subdevdata(sd);
- struct regval_list regval;
int ret;
u8 val;
- regval.reg_num = BANK_SEL;
- regval.value = BANK_SEL_SENS;
- ret = ov2640_write_array(client, ®val);
+ ret = ov2640_write_single(client, BANK_SEL, BANK_SEL_SENS);
if (ret < 0)
return ret;
--
1.7.10.4
next prev parent reply other threads:[~2012-09-23 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 18:28 [PATCH v2 1/3] ov2640: select sensor register bank before applying h/v-flip settings Frank Schäfer
2012-09-23 18:28 ` [PATCH v2 2/3] ov2640: add support for V4L2_MBUS_FMT_YUYV8_2X8, V4L2_MBUS_FMT_RGB565_2X8_BE Frank Schäfer
2012-09-23 20:36 ` Guennadi Liakhovetski
2012-09-23 18:28 ` Frank Schäfer [this message]
2012-09-23 20:43 ` [PATCH v2 3/3] ov2640: simplify single register writes Guennadi Liakhovetski
2012-09-23 20:06 ` Frank Schäfer
2012-09-23 21:23 ` Guennadi Liakhovetski
2012-09-23 20:37 ` Frank Schäfer
2012-09-23 20:21 ` [PATCH v2 1/3] ov2640: select sensor register bank before applying h/v-flip settings Guennadi Liakhovetski
2012-09-23 19:41 ` Frank Schäfer
2012-09-23 20:47 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348424926-12864-3-git-send-email-fschaefer.oss@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=maramaopercheseimorto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.