From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 09/19] block: purge s->aligned_buf and s->aligned_buf_size from raw-posix.c
Date: Mon, 24 Sep 2012 16:26:38 +0200 [thread overview]
Message-ID: <1348496808-8159-10-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1348496808-8159-1-git-send-email-kwolf@redhat.com>
From: Jeff Cody <jcody@redhat.com>
The aligned_buf pointer and aligned_buf size are no longer used in
raw_posix.c, so remove all references to them.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/raw-posix.c | 21 +--------------------
1 files changed, 1 insertions(+), 20 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 1e727eb..0ffb3d0 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -133,8 +133,6 @@ typedef struct BDRVRawState {
int use_aio;
void *aio_ctx;
#endif
- uint8_t *aligned_buf;
- unsigned aligned_buf_size;
#ifdef CONFIG_XFS
bool is_xfs : 1;
#endif
@@ -259,23 +257,10 @@ static int raw_open_common(BlockDriverState *bs, const char *filename,
return ret;
}
s->fd = fd;
- s->aligned_buf = NULL;
-
- if ((bdrv_flags & BDRV_O_NOCACHE)) {
- /*
- * Allocate a buffer for read/modify/write cycles. Chose the size
- * pessimistically as we don't know the block size yet.
- */
- s->aligned_buf_size = 32 * MAX_BLOCKSIZE;
- s->aligned_buf = qemu_memalign(MAX_BLOCKSIZE, s->aligned_buf_size);
- if (s->aligned_buf == NULL) {
- goto out_close;
- }
- }
/* We're falling back to POSIX AIO in some cases so init always */
if (paio_init() < 0) {
- goto out_free_buf;
+ goto out_close;
}
#ifdef CONFIG_LINUX_AIO
@@ -292,8 +277,6 @@ static int raw_open_common(BlockDriverState *bs, const char *filename,
return 0;
-out_free_buf:
- qemu_vfree(s->aligned_buf);
out_close:
qemu_close(fd);
return -errno;
@@ -402,8 +385,6 @@ static void raw_close(BlockDriverState *bs)
if (s->fd >= 0) {
qemu_close(s->fd);
s->fd = -1;
- if (s->aligned_buf != NULL)
- qemu_vfree(s->aligned_buf);
}
}
--
1.7.6.5
next prev parent reply other threads:[~2012-09-24 14:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:26 [Qemu-devel] [PULL 00/19] Block patches Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 01/19] blockdev: preserve readonly and snapshot states across media changes Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 02/19] block: correctly set the keep_read_only flag Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 03/19] block: make bdrv_set_enable_write_cache() modify open_flags Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 04/19] block: Framework for reopening files safely Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 05/19] block: move aio initialization into a helper function Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 06/19] block: move open flag parsing in raw block drivers to helper functions Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 07/19] block: do not parse BDRV_O_CACHE_WB in block drivers Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 08/19] block: use BDRV_O_NOCACHE instead of s->aligned_buf in raw-posix.c Kevin Wolf
2012-09-24 14:26 ` Kevin Wolf [this message]
2012-09-24 14:26 ` [Qemu-devel] [PATCH 10/19] block: raw-posix image file reopen Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 11/19] block: raw " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 12/19] block: qed " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 13/19] block: qcow2 " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 14/19] block: qcow " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 15/19] block: vmdk " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 16/19] block: vdi " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 17/19] block: vpc " Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 18/19] block: convert bdrv_commit() to use bdrv_reopen() Kevin Wolf
2012-09-24 14:26 ` [Qemu-devel] [PATCH 19/19] block: remove keep_read_only flag from BlockDriverState struct Kevin Wolf
2012-09-25 23:26 ` [Qemu-devel] [PULL 00/19] Block patches Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348496808-8159-10-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.