From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG9ck-0007AY-Dn for qemu-devel@nongnu.org; Mon, 24 Sep 2012 10:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TG9ce-00077L-AN for qemu-devel@nongnu.org; Mon, 24 Sep 2012 10:27:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG9ce-00077D-2T for qemu-devel@nongnu.org; Mon, 24 Sep 2012 10:26:56 -0400 From: Kevin Wolf Date: Mon, 24 Sep 2012 16:26:32 +0200 Message-Id: <1348496808-8159-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1348496808-8159-1-git-send-email-kwolf@redhat.com> References: <1348496808-8159-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 03/19] block: make bdrv_set_enable_write_cache() modify open_flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Jeff Cody bdrv_set_enable_write_cache() sets the bs->enable_write_cache flag, but without the flag recorded in bs->open_flags, then next time a reopen() is performed the enable_write_cache setting may be inadvertently lost. This will set the flag in open_flags, so it is preserved across reopens. Signed-off-by: Jeff Cody Signed-off-by: Kevin Wolf --- block.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 4c0e7f5..458bcc9 100644 --- a/block.c +++ b/block.c @@ -2168,6 +2168,13 @@ int bdrv_enable_write_cache(BlockDriverState *bs) void bdrv_set_enable_write_cache(BlockDriverState *bs, bool wce) { bs->enable_write_cache = wce; + + /* so a reopen() will preserve wce */ + if (wce) { + bs->open_flags |= BDRV_O_CACHE_WB; + } else { + bs->open_flags &= ~BDRV_O_CACHE_WB; + } } int bdrv_is_encrypted(BlockDriverState *bs) -- 1.7.6.5