From: Jonathan Rajotte-Julien via lttng-dev <lttng-dev@lists.lttng.org>
To: Alexander Kanavin <alex@linutronix.de>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH] lttng-ust-common: link with liburcu explicitly
Date: Thu, 2 Dec 2021 15:20:28 -0500 (EST) [thread overview]
Message-ID: <1348532811.12349.1638476428245.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20211202200412.146288-1-alex@linutronix.de>
Hi Alexander,
Thanks for sending this patch. Could you provide more details regarding the linking errors?
lttng-ust must not depends on liburcu at runtime since commit 10544ee8af31afb239e3dfa71cb2fe09d3de3771
commit 10544ee8af31afb239e3dfa71cb2fe09d3de3771
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Wed Nov 11 17:28:06 2020 -0500
Remove runtime dependency on liburcu shared objects
Remove the runtime dependency on:
- liblurcu-bp.so
- liblurcu-cds.so
- compat futex code.
By integrating those into the lttng-ust project.
For rculfhash, only the minimum pieces needed by lttng-ust are
integrated (no auto-resize, no accounting).
lttng-ust still requires liburcu at build time for header dependencies.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Idffb205b27b1bb0f972523c3ce3bdaf25bfe1710
Cheers
----- Original Message -----
> From: "Alexander Kanavin" <alex@linutronix.de>
> To: "lttng-dev" <lttng-dev@lists.lttng.org>, "Francis Deslauriers" <francis.deslauriers@efficios.com>, "jonathan
> rajotte-julien" <jonathan.rajotte-julien@efficios.com>
> Cc: "Alexander Kanavin" <alex@linutronix.de>
> Sent: Thursday, December 2, 2021 3:04:12 PM
> Subject: [PATCH] lttng-ust-common: link with liburcu explicitly
> Otherwise linking errors are seen on x86-32.
> ---
> src/lib/lttng-ust-common/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/lib/lttng-ust-common/Makefile.am
> b/src/lib/lttng-ust-common/Makefile.am
> index caeea2be..0130628c 100644
> --- a/src/lib/lttng-ust-common/Makefile.am
> +++ b/src/lib/lttng-ust-common/Makefile.am
> @@ -15,6 +15,7 @@ liblttng_ust_common_la_SOURCES = \
>
> liblttng_ust_common_la_LIBADD = \
> $(top_builddir)/src/common/libcommon.la \
> + $(URCU_LIBS) \
> $(DL_LIBS)
>
> liblttng_ust_common_la_LDFLAGS = -no-undefined -version-info
> $(LTTNG_UST_LIBRARY_VERSION)
> --
> 2.20.1
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2021-12-02 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 20:04 [lttng-dev] [PATCH] lttng-ust-common: link with liburcu explicitly Alexander Kanavin via lttng-dev
2021-12-02 20:20 ` Jonathan Rajotte-Julien via lttng-dev [this message]
2021-12-02 20:47 ` [lttng-dev] ?==?utf-8?q? [PATCH]?==?utf-8?q? " Alexander Kanavin via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348532811.12349.1638476428245.JavaMail.zimbra@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=alex@linutronix.de \
--cc=jonathan.rajotte-julien@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.