From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1TGX07-0007ZW-EB for mharc-grub-devel@gnu.org; Tue, 25 Sep 2012 11:24:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGX00-0007BO-67 for grub-devel@gnu.org; Tue, 25 Sep 2012 11:24:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGWzz-0000PV-2t for grub-devel@gnu.org; Tue, 25 Sep 2012 11:24:36 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:60463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGWzy-0000PN-Pf for grub-devel@gnu.org; Tue, 25 Sep 2012 11:24:34 -0400 Received: by lbok6 with SMTP id k6so335027lbo.0 for ; Tue, 25 Sep 2012 08:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:mime-version:content-transfer-encoding; bh=KMTfNMqEnKDax2F8QDb77EPdOC8MTsg9LbXQ6vr3vU4=; b=ocTo4pXOO5xde/8u5EyQCCvlJlr4+H/YpjTPVzWlkzhWoBAaAwFV0l4aLxrs2zJBgm 6816lJlJMd4Ed/oIQ954gmC2+GqG/Md39GiIS9IahTSNcfFUfLxhIJbQt7yWYywQiWB2 2RxFQju/sB0yw3uoSSse8nuLcUFcD6jgmwd80y0ZqduEa7Ozy/NzKzszoXDbfDjXEASa /pdebPji+qC/Z5QsfbqAXpLJru9uL+6tEJaP2rXG4a2EHY8UHA1xct4nSszKT2vqTcVs FC0jmOqaLXaO8t8xP/zuZWP3i1xuhCWhZmNU8kALR2oU5EByHtL3JZ59LkEmRRw9i61i FQCg== Received: by 10.112.36.138 with SMTP id q10mr5788129lbj.63.1348586658484; Tue, 25 Sep 2012 08:24:18 -0700 (PDT) Received: from [192.168.10.142] (ppp83-237-18-220.pppoe.mtu-net.ru. [83.237.18.220]) by mx.google.com with ESMTPS id fr11sm181438lab.5.2012.09.25.08.24.16 (version=SSLv3 cipher=OTHER); Tue, 25 Sep 2012 08:24:17 -0700 (PDT) Message-ID: <1348586655.1610.3.camel@opensuse.site> Subject: Re: [PATCH] suppress error message "/grub2/locale/en.mo.gz not found" From: Andrey Borzenkov To: Michael Chang Date: Tue, 25 Sep 2012 19:24:15 +0400 In-Reply-To: References: <1348469509-21079-1-git-send-email-mchang@suse.com> <506029C8.8000804@kiilerich.com> <1348512057.1612.10.camel@opensuse.site> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.217.169 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 15:24:41 -0000 В Вт., 25/09/2012 в 12:46 +0800, Michael Chang пишет: > 2012/9/25 Andrey Borzenkov : > > В Пн., 24/09/2012 в 11:37 +0200, Mads Kiilerich пишет: > >> On 09/24/2012 08:51 AM, Michael Chang wrote: > >> > We don't insert gettext module if message catalog file missing to > >> > prevent error message from being logged. [...] > > > > What about removing this error message altogether? Under OS gettext does > > not complaint when catalog does not exist; why should it do it here? > > Having English interface is enough indication that message catalog was > > not found. > > I agree with you. IMHO the problem is it's not emitted directly from > gettext module but from common underlying fs level, removing it would > lead to other message which is fatal be ignored as well. > As far as I can tell it is emitted explicitly when setting "lang": grub-core/gettext/gettext.c:grub_gettext_env_write_lang() grub_err_t err; err = grub_gettext_init_ext (&main_context, val, grub_env_get ("locale_dir"), grub_env_get ("prefix")); if (err) grub_print_error (); and later. There are some more places which also try to reload catalog. May be this messages can be turned into debugging message instead of error. -andrey