From: Phil Blundell <philb@gnu.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gcc-configure-cross: factor out --enable-threads argument into ${GCCTHREADS}
Date: Wed, 26 Sep 2012 10:57:41 +0100 [thread overview]
Message-ID: <1348653462.31293.92.camel@phil-desktop> (raw)
In-Reply-To: <20120926095459.GE3313@jama.jama.net>
On Wed, 2012-09-26 at 11:54 +0200, Martin Jansa wrote:
> On Wed, Sep 26, 2012 at 10:45:18AM +0100, Phil Blundell wrote:
> > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > index 908ad3e..504bfaa 100644
> > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > @@ -26,12 +26,13 @@ EXTRA_OECONF_INITIAL ?= ""
> > EXTRA_OECONF_INTERMEDIATE ?= ""
> >
> > GCCMULTILIB = "--disable-multilib"
> > +GCCTHREADS = "posix"
> >
> > EXTRA_OECONF = "${@['--enable-clocale=generic', ''][d.getVar('USE_NLS', True) != 'no']} \
> > --with-gnu-ld \
> > --enable-shared \
> > --enable-languages=${LANGUAGES} \
> > - --enable-threads=posix \
> > + --enable-threads=${GCCTHREADS} \
> > ${GCCMULTILIB} \
> > --enable-c99 \
> > --enable-long-long \
> > --
> > 1.7.10.4
>
> Missing PR bump
Does it really need one? It doesn't have any impact on the value that
EXTRA_OECONF ends up with, and bumping the PRs on all the various .bb
files would make the patch about ten times the size. I can do that if
you insist but it seems like a bit of a waste of time.
p.
next prev parent reply other threads:[~2012-09-26 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 9:45 [PATCH] gcc-configure-cross: factor out --enable-threads argument into ${GCCTHREADS} Phil Blundell
2012-09-26 9:54 ` Martin Jansa
2012-09-26 9:57 ` Phil Blundell [this message]
2012-09-26 10:01 ` Martin Jansa
2012-09-26 10:28 ` Phil Blundell
2012-09-26 13:46 ` Richard Purdie
2012-09-26 10:46 ` Henning Heinold
2012-09-26 10:50 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348653462.31293.92.camel@phil-desktop \
--to=philb@gnu.org \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.