All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Phil Blundell <philb@gnu.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: overuse of bitbake flags considered harmful
Date: Thu, 27 Sep 2012 16:27:43 +0100	[thread overview]
Message-ID: <1348759663.8493.12.camel@ted> (raw)
In-Reply-To: <1348748538.32611.18.camel@phil-desktop>

On Thu, 2012-09-27 at 13:22 +0100, Phil Blundell wrote:
> I was mildly amused to discover, the other day, that the output of
> "bitbake -e rpm | grep PACKAGECONFIG" is not quite as one might naïvely
> expect.  
> 
> I guess the right response to this is perhaps that bitbake ought
> nowadays to find some other way to store its own internal state, since
> the idiom of using flags is pretty well established in oe-core.

For those who don't realise what's going on here, the output is:

python PACKAGECONFIG () {
db bzip2 zlib beecrypt openssl libelf python}

since "python" is a flag bitbake uses to identify python functions too.

I suspect the better solution would be to use "_python" internally since
we already have a convention within bitbake of prefixing internally used
flags with "_".

http://git.yoctoproject.org/cgit.cgi/poky/commit/bitbake/lib/bb/data_smart.py?id=49bc007c80e429090c4db51e30c5ce27e8a72558
http://git.yoctoproject.org/cgit.cgi/poky/commit/bitbake/lib/bb/data_smart.py?id=980d658f3f1e6c5b459f741385533a11d35009ca

This would mean the metadata shouldn't use that namespace but I think we
can live with that.

Cheers,

Richard






      reply	other threads:[~2012-09-27 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 12:22 overuse of bitbake flags considered harmful Phil Blundell
2012-09-27 15:27 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348759663.8493.12.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=philb@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.