All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] lib/bb/data.py: improve output for expansion errors
Date: Thu, 27 Sep 2012 16:42:23 +0100	[thread overview]
Message-ID: <1348760543.11186.0.camel@ted> (raw)
In-Reply-To: <1348582637-31533-1-git-send-email-paul.eggleton@linux.intel.com>

On Tue, 2012-09-25 at 15:17 +0100, Paul Eggleton wrote:
> Instead of logging the function/variable separately as a NOTE when
> failing to expand, re-raise ExpansionError with more contextual
> information. This means that the full details are reported in Hob as
> well as actually reporting the original error message in any UI where
> we previously did not. For example, we used to get this with tab/space
> indentation issues in a python function:
> 
> NOTE: Error expanding variable populate_packages
> ERROR: Unable to parse /path/to/recipename.bb
> 
> Now, we will get this:
> 
> ERROR: ExpansionError during parsing /path/to/recipename.bb: Failure
>  expanding variable populate_packages: IndentationError: unindent does
>  not match any outer indentation level (<string>, line 4)
> 
> Fixes [YOCTO #3162].
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  bitbake/lib/bb/data.py       |    5 ++---
>  bitbake/lib/bb/data_smart.py |    5 ++++-
>  2 files changed, 6 insertions(+), 4 deletions(-)

Merged to master, thanks.

Richard




      reply	other threads:[~2012-09-27 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 14:17 [PATCH] lib/bb/data.py: improve output for expansion errors Paul Eggleton
2012-09-27 15:42 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348760543.11186.0.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.