From: Lucas Stach <dev@lynxeye.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra: add Colibri T20 board support
Date: Fri, 28 Sep 2012 01:13:55 +0200 [thread overview]
Message-ID: <1348787635.1432.40.camel@tellur> (raw)
In-Reply-To: <5064DCA4.2040100@wwwdotorg.org>
Am Donnerstag, den 27.09.2012, 17:09 -0600 schrieb Stephen Warren:
> On 09/27/2012 05:03 PM, Lucas Stach wrote:
> > Am Donnerstag, den 27.09.2012, 16:49 -0600 schrieb Stephen Warren:
> >> On 09/27/2012 03:52 PM, Lucas Stach wrote:
> >>> This adds board support for the Toradex Colibri T20 module.
> >>>
> >>> Working functions:
> >>> - MMC boot
> >>> - USB boot
> >>> - Network
> >>> - NAND environment
> >>
> >>> diff --git a/board/toradex/colibri_t20/colibri_t20.c b/board/toradex/colibri_t20/colibri_t20.c
> >>
> >>> +#ifdef CONFIG_USB_EHCI_TEGRA
> >>> +void pin_mux_usb(void)
> >>> +{
> >>> + /* USB 1 aka Tegra USB port 3 */
> >>> + pinmux_tristate_disable(PINGRP_SPIG);
> >>> +
> >>> + /* USB 3 aka Tegra USB port 2 */
> >>
> >> Re: the comments:
> >>
> >> The only reason other board files have HW port USB3 listed as DT alias
> >> usb0 is because HW port USB3 was the most useful port on those boards,
> >> and the Tegra USB driver only supported the first listed HW port. Now
> >> that the Tegra USB driver supports any/all of the HW ports, you could
> >> just arrange the aliases in DT so that HW USB1 == user-visible USB1, etc.
> >>
> > I arranged them in that way so they match best with the connector label
> > on the carrier board.
>
> OK, that makes sense then.
>
> >>> diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h
> >>
> >>> +/* Environment in NAND, 64K is a bit excessive but erase block is 256K anyway */
> >>> +#define CONFIG_ENV_IS_IN_NAND
> >>> +#define CONFIG_ENV_OFFSET (SZ_2M)
> >>> +#undef CONFIG_ENV_SIZE /* undef size from tegra20-common.h */
> >>> +#define CONFIG_ENV_SIZE (SZ_64K)
> >>
> >> Any particular reason to change the environment size? All the other
> >> boards that have eMMC put the environment at the end of the second eMMC
> >> boot-block even when NAND is also available. Is there a particular
> >> reason not to do so for Colibri too? Does Colibri boot (BCT+bootloader
> >> image) from eMMC or NAND?
> >>
> > Colibri has no eMMC, it boots from NAND.
>
> Oh, so "MMC boot" in the patch description should be "SD boot" then?
>
Right, last minute additions don't work really well. ;)
prev parent reply other threads:[~2012-09-27 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 21:52 [U-Boot] [PATCH] tegra: add Colibri T20 board support Lucas Stach
2012-09-27 22:49 ` Stephen Warren
2012-09-27 23:03 ` Lucas Stach
2012-09-27 23:09 ` Stephen Warren
2012-09-27 23:13 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348787635.1432.40.camel@tellur \
--to=dev@lynxeye.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.